linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH v2 2/2] tracing: Reset ftrace_graph_filter_enabled if count is zero
Date: Fri, 12 Apr 2013 14:13:16 -0400	[thread overview]
Message-ID: <1365790396.9609.93.camel@gandalf.local.home> (raw)
In-Reply-To: <1365663698-2413-1-git-send-email-namhyung@kernel.org>

On Thu, 2013-04-11 at 16:01 +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
> 
> The ftrace_graph_count can be decreased with a "!" pattern, so that
> the enabled flag should be updated too.

Thanks!

Once again I'll push patch 1 to 3.9 and stable as that's a nasty bug.

But this patch isn't that big of a deal, and as we are in the later
-rc's I'll label it with stable and add it to the 3.10 queue.

Thanks,

-- Steve

> 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  kernel/trace/ftrace.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index be2bcb7ab2f7..daf8df20b764 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -3779,7 +3779,8 @@ out:
>  	if (fail)
>  		return -EINVAL;
>  
> -	ftrace_graph_filter_enabled = 1;
> +	ftrace_graph_filter_enabled = !!(*idx);
> +
>  	return 0;
>  }
>  



      reply	other threads:[~2013-04-12 18:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11  6:55 [PATCH 1/2] tracing: Fix possible NULL pointer dereferences Namhyung Kim
2013-04-11  6:55 ` [PATCH 2/2] tracing: Reset ftrace_graph_filter_enabled if count is zero Namhyung Kim
2013-04-11  7:01   ` [PATCH v2 " Namhyung Kim
2013-04-12 18:13     ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365790396.9609.93.camel@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).