From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
broonie@kernel.org, srinivas.kandagatla@linaro.org,
jank@cadence.com, slawomir.blauciak@intel.com,
Sanyog Kale <sanyog.r.kale@intel.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH v4 05/11] soundwire: intel: update interfaces between ASoC and SoundWire
Date: Wed, 11 Dec 2019 08:22:26 -0600 [thread overview]
Message-ID: <13e24f85-bf48-cf63-d738-dfb62b28a814@linux.intel.com> (raw)
In-Reply-To: <20191211114247.GI2536@vkoul-mobl>
On 12/11/19 5:42 AM, Vinod Koul wrote:
> On 09-12-19, 17:55, Pierre-Louis Bossart wrote:
>
>> @@ -138,8 +126,6 @@ static struct sdw_intel_ctx
>> pdevinfo.name = "int-sdw";
>> pdevinfo.id = i;
>> pdevinfo.fwnode = acpi_fwnode_handle(adev);
>> - pdevinfo.data = &link->res;
>> - pdevinfo.size_data = sizeof(link->res);
>>
>> pdev = platform_device_register_full(&pdevinfo);
>> if (IS_ERR(pdev)) {
>> @@ -224,10 +210,8 @@ EXPORT_SYMBOL(sdw_intel_init);
>
> This is still exported
>
>> struct sdw_intel_res {
>> + int count;
>> void __iomem *mmio_base;
>> int irq;
>> acpi_handle handle;
>> struct device *parent;
>> const struct sdw_intel_ops *ops;
>> - void *arg;
>> + struct device *dev;
>> + u32 link_mask;
>> };
>>
>> -void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res);
>
> But prototype removed, so i think this is a miss in the series, can you
> fix that up
This is updated in a later patch that implements the new interfaces
-EXPORT_SYMBOL(sdw_intel_init);
+EXPORT_SYMBOL(sdw_intel_acpi_scan);
I will fix this but since there is no user for that function there will
be no impact.
next prev parent reply other threads:[~2019-12-11 14:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 23:55 [PATCH v4 00/11] soundwire: update ASoC interfaces Pierre-Louis Bossart
2019-12-09 23:55 ` [PATCH v4 01/11] soundwire: sdw_slave: add probe_complete structure and new fields Pierre-Louis Bossart
2019-12-09 23:55 ` [PATCH v4 02/11] soundwire: sdw_slave: add enumeration_complete structure Pierre-Louis Bossart
2019-12-09 23:55 ` [PATCH v4 03/11] soundwire: sdw_slave: add initialization_complete definition Pierre-Louis Bossart
2019-12-09 23:55 ` [PATCH v4 04/11] soundwire: sdw_slave: track unattach_request to handle all init sequences Pierre-Louis Bossart
2019-12-09 23:55 ` [PATCH v4 05/11] soundwire: intel: update interfaces between ASoC and SoundWire Pierre-Louis Bossart
2019-12-11 11:42 ` Vinod Koul
2019-12-11 14:22 ` Pierre-Louis Bossart [this message]
2019-12-09 23:55 ` [PATCH v4 06/11] soundwire: intel: update stream callbacks for hwparams/free stream operations Pierre-Louis Bossart
2019-12-09 23:55 ` [PATCH v4 07/11] soundwire: intel: update headers for interrupts Pierre-Louis Bossart
2019-12-09 23:55 ` [PATCH v4 08/11] soundwire: intel: add link_list to handle interrupts with a single thread Pierre-Louis Bossart
2019-12-09 23:55 ` [PATCH v4 09/11] soundwire: intel: add prototype for WAKEEN interrupt processing Pierre-Louis Bossart
2019-12-09 23:55 ` [PATCH v4 10/11] soundwire: intel: add mutex for shared SHIM register access Pierre-Louis Bossart
2019-12-09 23:55 ` [PATCH v4 11/11] soundwire: intel: add clock stop quirks Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13e24f85-bf48-cf63-d738-dfb62b28a814@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).