From: Paul Bolle <pebolle@tiscali.nl>
To: Geoff Levand <geoff@infradead.org>
Cc: Vivek Goyal <vgoyal@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Eric Biederman <ebiederm@xmission.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Morton <akpm@linux-foundation.org>,
kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, maximilian attems <max@stro.at>
Subject: Re: [PATCH 1/5] kexec: Fix make headers_check
Date: Mon, 06 Oct 2014 16:12:14 +0200 [thread overview]
Message-ID: <1412604734.4054.72.camel@x220> (raw)
In-Reply-To: <1409402838.21896.99.camel@x220>
Hi Geoff,
On Sat, 2014-08-30 at 14:47 +0200, Paul Bolle wrote:
> [Added Peter Anvin.]
>
> On Mon, 2014-08-25 at 13:22 -0400, Vivek Goyal wrote:
> > On Fri, Aug 22, 2014 at 06:39:47PM +0000, Geoff Levand wrote:
> > > Remove the unneded declaration for a kexec_load() routine.
> > >
> > > Fixes errors like these when running 'make headers_check':
> > >
> > > include/uapi/linux/kexec.h: userspace cannot reference function or variable defined in the kernel
> > >
> > > Signed-off-by: Geoff Levand <geoff@infradead.org>
> >
> > I think Paul Bolle tried to remove this in the past and maximilian
> > had objections.
> >
> > http://lists.infradead.org/pipermail/kexec/2014-January/010902.html
>
> I've wanted to resend my patch, perhaps with a new commit explanation,
> for quite some time now. I never got around doing that.
>
> > I can't see that how exporting kernel prototype helps here.
>
> It doesn't, for the reasons I've set out in
> http://lists.infradead.org/pipermail/kexec/2014-January/010900.html . In
> short: why bother using this prototype if one still needs to define the
> matching function oneself?
>
> > kexec-tools
> > seems to be using syscall(__NR_kexec_load) directly for non-xen case. So
> > I would be fine with removing this definition. Just trying to make sure
> > that it does not break any other library or users of this declaration.
>
> Obviously, this can only break compiling those libraries, or other
> users. It can't break already compiled binaries. Besides I don't think
> those libraries, etc actually exist. Maximilian mentioned klibc in
> January, but I wasn't able to find a version of klibc that cared about
> this prototype. No one pointed me at a version that does (or any other
> library, etc., for that matter).
>
> (If we do decide to keep this prototype, we should special case this
> prototype in headers_check.pl just to silence the build.)
>
> The above can be summarized like this:
> Acked-by: Paul Bolle <pebolle@tiscali.nl>
It seems not much happened after I added my Acked-by. I assume you still
want to get this merged. Is that correct?
Paul Bolle
next prev parent reply other threads:[~2014-10-06 14:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 18:39 [PATCH 0/5] kexec: minor fixups and enhancements Geoff Levand
2014-08-22 18:39 ` [PATCH 3/5] kexec: Add bit definitions for kimage entry flags Geoff Levand
2014-08-25 17:52 ` Vivek Goyal
2014-08-22 18:39 ` [PATCH 1/5] kexec: Fix make headers_check Geoff Levand
2014-08-25 17:22 ` Vivek Goyal
2014-08-30 12:47 ` Paul Bolle
2014-10-06 14:12 ` Paul Bolle [this message]
2014-10-06 17:34 ` Geoff Levand
2014-10-06 18:21 ` Paul Bolle
2014-10-06 19:28 ` Geoff Levand
2014-10-06 17:44 ` H. Peter Anvin
2014-08-22 18:39 ` [PATCH 5/5] powerpc/kexec: Use global IND_FLAGS macro Geoff Levand
2014-08-22 18:39 ` [PATCH 4/5] kexec: Add " Geoff Levand
2014-08-25 17:54 ` Vivek Goyal
2014-08-22 18:39 ` [PATCH 2/5] kexec: Simplify conditional Geoff Levand
2014-08-25 17:42 ` Vivek Goyal
2014-08-25 16:59 ` [PATCH 0/5] kexec: minor fixups and enhancements Vivek Goyal
2014-08-26 7:41 ` Dave Young
2014-08-27 0:33 ` Geoff Levand
2014-08-27 0:42 ` Vivek Goyal
2014-10-07 0:21 ` [PATCH V2 0/5] kexec: Minor " Geoff Levand
2014-10-07 0:21 ` [PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro Geoff Levand
2014-10-07 17:52 ` Vivek Goyal
2014-11-12 19:29 ` [PATCH V3] kexec: Add " Geoff Levand
2014-11-12 23:06 ` Benjamin Herrenschmidt
2014-10-07 0:21 ` [PATCH V22/5] kexec: Simplify conditional Geoff Levand
2014-10-07 0:21 ` [PATCH V21/5] kexec: Fix make headers_check Geoff Levand
2014-10-07 0:21 ` [PATCH V23/5] kexec: Add bit definitions for kimage entry flags Geoff Levand
2014-10-07 0:21 ` [PATCH V24/5] kexec: Add IND_FLAGS macro Geoff Levand
2014-10-07 20:26 ` [PATCH V3 4/5] " Geoff Levand
2014-11-13 0:19 ` [PATCH V3 0/4] kexec: minor fixups and enhancements Geoff Levand
2014-11-13 0:19 ` [PATCH V3 3/4] kexec: Add bit definitions for kimage entry flags Geoff Levand
2014-11-13 0:19 ` [PATCH V3 4/4] kexec: Add IND_FLAGS macro Geoff Levand
2014-11-13 0:19 ` [PATCH V3 2/4] kexec: Simplify conditional Geoff Levand
2014-11-13 0:19 ` [PATCH V3 1/4] kexec: Fix make headers_check Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412604734.4054.72.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=ebiederm@xmission.com \
--cc=geoff@infradead.org \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=max@stro.at \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).