From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: Re: [PATCH 5/6] regulator: max77686: Remove support for board files
Date: Wed, 05 Nov 2014 09:33:40 +0100 [thread overview]
Message-ID: <1415176420.15850.5.camel@AMDC1943> (raw)
In-Reply-To: <20141104204647.GE3815@sirena.org.uk>
On wto, 2014-11-04 at 20:46 +0000, Mark Brown wrote:
> On Tue, Nov 04, 2014 at 09:49:45AM +0100, Krzysztof Kozlowski wrote:
> > The driver is used only on Exynos based boards with DTS support.
> > Simplify the driver and remove dead (unused) entries in platform_data
> > structure.
>
> This mostly isn't actually removing platform data support as far as I
> can see? It's removing some spurious error checks for missing platform
> data (which is good) and converting to use the core DT parsing (which is
> also good) but just leaving this:
>
> > - struct max77686_platform_data *pdata = dev_get_platdata(iodev->dev);
>
> > - config.init_data = pdata->regulators[i].initdata;
>
> would keep platform data support there. What problem is removing
> platform data support solving?
There isn't specific problem to solve. The purpose here is to remove
legacy and old code which really is not used. On Samsung boards with
mainline kernel the platform data is not used for a long, long time.
On our vendor kernels (for example these published on
opensource.samsung.com for Android and Tizen devices) this driver is not
used... because whole kernel is different and all drivers for Samsung
specific stuff (SoC, PMIC, sensors, LCD etc.) are developed by vendor.
In my humble opinion there aren't any users of this code. Removing it
helps in maintaining the driver.
Best regards,
Krzysztof
next prev parent reply other threads:[~2014-11-05 8:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 8:49 [PATCH 0/6] regulator: max77686/802: Cleanup Krzysztof Kozlowski
2014-11-04 8:49 ` [PATCH 1/6] regulator: max77686: Consistently index opmode array by rdev id Krzysztof Kozlowski
2014-11-04 20:41 ` Mark Brown
2014-11-04 8:49 ` [PATCH 2/6] regulator: max77686: Initialize opmode explicitly to normal mode Krzysztof Kozlowski
2014-11-04 20:42 ` Mark Brown
2014-11-04 8:49 ` [RFT 3/6] regulator: max77802: Don't ignore return value of current opmode Krzysztof Kozlowski
2014-11-04 20:47 ` Mark Brown
2014-11-04 8:49 ` [RFT 4/6] regulator: max77802: Remove support for board files Krzysztof Kozlowski
2014-11-04 8:49 ` [PATCH 5/6] regulator: max77686: " Krzysztof Kozlowski
2014-11-04 20:46 ` Mark Brown
2014-11-05 8:33 ` Krzysztof Kozlowski [this message]
2014-11-04 8:49 ` [PATCH 6/6] mfd: max77686/802: " Krzysztof Kozlowski
2014-11-04 9:24 ` [PATCH 0/6] regulator: max77686/802: Cleanup Javier Martinez Canillas
2014-11-04 9:25 ` Krzysztof Kozlowski
2014-11-04 20:42 ` Mark Brown
2014-11-05 8:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415176420.15850.5.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).