linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: kernel-janitors@vger.kernel.org,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	daniel@iogearbox.net
Subject: [PATCH 2/15] powerpc: don't export static symbol
Date: Wed, 11 Mar 2015 17:56:24 +0100	[thread overview]
Message-ID: <1426092997-30605-3-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1426092997-30605-1-git-send-email-Julia.Lawall@lip6.fr>

From: Julia Lawall <Julia.Lawall@lip6.fr>

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
type T;
identifier f;
@@

static T f (...) { ... }

@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@

-EXPORT_SYMBOL(f);
// </smpl>

Furthermore, the function is never used, so its definition is dropped as
well.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 arch/powerpc/sysdev/qe_lib/qe_io.c |   25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/arch/powerpc/sysdev/qe_lib/qe_io.c b/arch/powerpc/sysdev/qe_lib/qe_io.c
index d099941..7ea0174 100644
--- a/arch/powerpc/sysdev/qe_lib/qe_io.c
+++ b/arch/powerpc/sysdev/qe_lib/qe_io.c
@@ -190,28 +190,3 @@ int par_io_of_config(struct device_node *np)
 	return 0;
 }
 EXPORT_SYMBOL(par_io_of_config);
-
-#ifdef DEBUG
-static void dump_par_io(void)
-{
-	unsigned int i;
-
-	printk(KERN_INFO "%s: par_io=%p\n", __func__, par_io);
-	for (i = 0; i < num_par_io_ports; i++) {
-		printk(KERN_INFO "	cpodr[%u]=%08x\n", i,
-			in_be32(&par_io[i].cpodr));
-		printk(KERN_INFO "	cpdata[%u]=%08x\n", i,
-			in_be32(&par_io[i].cpdata));
-		printk(KERN_INFO "	cpdir1[%u]=%08x\n", i,
-			in_be32(&par_io[i].cpdir1));
-		printk(KERN_INFO "	cpdir2[%u]=%08x\n", i,
-			in_be32(&par_io[i].cpdir2));
-		printk(KERN_INFO "	cppar1[%u]=%08x\n", i,
-			in_be32(&par_io[i].cppar1));
-		printk(KERN_INFO "	cppar2[%u]=%08x\n", i,
-			in_be32(&par_io[i].cppar2));
-	}
-
-}
-EXPORT_SYMBOL(dump_par_io);
-#endif /* DEBUG */

  parent reply	other threads:[~2015-03-11 17:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 16:56 [PATCH 0/15] don't export static symbol Julia Lawall
2015-03-11 16:56 ` [PATCH 1/15] NFSv4.1: " Julia Lawall
2015-03-12 15:59   ` Trond Myklebust
2015-03-11 16:56 ` Julia Lawall [this message]
2015-03-11 16:56 ` [PATCH 3/15] net/mlx5_core: " Julia Lawall
2015-03-12  4:04   ` David Miller
2015-03-11 16:56 ` [PATCH 4/15] crypto: " Julia Lawall
2015-03-13 10:38   ` Herbert Xu
2015-03-11 16:56 ` [PATCH 5/15] clockevents: " Julia Lawall
2015-03-11 16:56 ` [PATCH 6/15] torture: " Julia Lawall
2015-03-11 16:56 ` [PATCH 7/15] media: pci: cx23885: " Julia Lawall
2015-03-11 16:56 ` [PATCH 8/15] libertas_tf: if_usb.c: " Julia Lawall
2015-03-13 14:18   ` [8/15] " Kalle Valo
2015-03-11 16:56 ` [PATCH 9/15] clk: " Julia Lawall
2015-03-12  6:03   ` Stephen Boyd
2015-03-11 16:56 ` [PATCH 10/15] scsi: " Julia Lawall
2015-03-11 16:56 ` [PATCH 11/15] ASoC: ab8500-codec: " Julia Lawall
2015-03-11 18:29   ` Mark Brown
2015-03-11 16:56 ` [PATCH 12/15] i82443bxgx_edac: " Julia Lawall
2015-03-11 19:48   ` Borislav Petkov
2015-03-11 16:56 ` [PATCH 13/15] ieee802154: " Julia Lawall
2015-03-11 18:17   ` Alexander Aring
2015-03-14 16:13   ` Marcel Holtmann
2015-03-11 16:56 ` [PATCH 14/15] ARM: cns3xxx: " Julia Lawall
2015-03-11 21:09   ` Arnd Bergmann
2015-03-13  5:59     ` Krzysztof Hałasa
2015-03-13 10:04       ` Arnd Bergmann
2015-03-11 16:56 ` [PATCH 15/15] iscsi-target: " Julia Lawall
2015-03-20 18:42   ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426092997-30605-3-git-send-email-Julia.Lawall@lip6.fr \
    --to=julia.lawall@lip6.fr \
    --cc=benh@kernel.crashing.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).