linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Paul Mundt <lethal@linux-sh.org>, <linux-sh@vger.kernel.org>
Subject: [PATCH 11/11] sh: mach-highlander/psw.c is tristate and should use module.h
Date: Thu, 30 Apr 2015 21:47:47 -0400	[thread overview]
Message-ID: <1430444867-22342-12-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com>

This file is controlled by a tristate Kconfig option, and hence
needs to include module.h so that it can get module_init() once
we relocate it from init.h into module.h in the future.

Note that module_exit() appears to be missing from the driver, so
it is questionable whether it would actually work for a removal
and reload cycle if it was configured for a modular build.

Cc: Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 arch/sh/boards/mach-highlander/psw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sh/boards/mach-highlander/psw.c b/arch/sh/boards/mach-highlander/psw.c
index 522786318d36..40e2b585d488 100644
--- a/arch/sh/boards/mach-highlander/psw.c
+++ b/arch/sh/boards/mach-highlander/psw.c
@@ -10,7 +10,7 @@
  * for more details.
  */
 #include <linux/io.h>
-#include <linux/init.h>
+#include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <mach/highlander.h>
-- 
2.2.1


  parent reply	other threads:[~2015-05-01  1:49 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01  1:47 [PATCH 00/11] Fix implicit includes of <module.h> that will break Paul Gortmaker
2015-05-01  1:47 ` [PATCH 01/11] drivers/crypto: include <module.h> for modular caam code Paul Gortmaker
2015-05-01  3:24   ` Herbert Xu
2015-05-01 13:40     ` Paul Gortmaker
2015-05-01  1:47 ` [PATCH 02/11] drivers/clk: include <module.h> for clk-max77xxx modular code Paul Gortmaker
2015-05-01 21:37   ` Stephen Boyd
2015-05-02  0:29     ` Paul Gortmaker
2015-05-01  1:47 ` [PATCH 03/11] drivers/gpio: include <module.h> for modular crystalcove code Paul Gortmaker
2015-05-12  7:38   ` Linus Walleij
2015-05-01  1:47 ` [PATCH 04/11] drivers/gpu: include <module.h> for modular rockchip code Paul Gortmaker
2015-05-01  1:47 ` [PATCH 05/11] drivers/hsi: include <module.h> for modular omap_ssi code Paul Gortmaker
2015-05-01  1:47 ` [PATCH 06/11] drivers/net: include <module.h> for modular stmmac_platform code Paul Gortmaker
2015-05-04  3:40   ` David Miller
2015-05-01  1:47 ` [PATCH 07/11] drivers/pcmcia: include <module.h> for modular xxs1500_ss code Paul Gortmaker
2015-05-04  9:32   ` Wolfram Sang
2015-05-01  1:47 ` [PATCH 08/11] drivers/pcmcia: include <module.h> for modular max77802 code Paul Gortmaker
2015-05-01 10:11   ` Mark Brown
2015-05-01 13:34     ` Paul Gortmaker
2015-05-01 14:04       ` Mark Brown
2015-05-01  1:47 ` [PATCH 09/11] drivers/scsi: include <module.h> for modular ufshcd-pltfrm code Paul Gortmaker
2015-05-01  2:35   ` James Bottomley
2015-05-01 13:37     ` Paul Gortmaker
2015-05-01 13:43       ` James Bottomley
2015-05-01  1:47 ` [PATCH 10/11] drivers/staging: include <module.h> for modular android tegra_ion code Paul Gortmaker
2015-05-01  1:47 ` Paul Gortmaker [this message]
2015-06-03 21:18 ` [PATCH] drivers/cpufreq: include <module.h> for modular exynos-cpufreq.c code Paul Gortmaker
2015-06-04  2:00   ` Krzysztof Kozlowski
2015-06-04  2:32   ` Viresh Kumar
2015-06-15 23:47   ` Rafael J. Wysocki
2015-06-15 23:53     ` Krzysztof Kozlowski
2015-06-16  3:28       ` Paul Gortmaker
2015-06-16 15:29       ` Paul Gortmaker
2015-06-17  0:36         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430444867-22342-12-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).