linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Ming Lin <mlin@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	lkml <linux-kernel@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] mempool based chained scatterlist alloc/free api
Date: Mon, 04 Apr 2016 07:01:36 -0700	[thread overview]
Message-ID: <1459778496.2315.1.camel@HansenPartnership.com> (raw)
In-Reply-To: <CAF1ivSY-xbhv47a3UCDWmDb9PsUpTSOmXDyRmSAzMactbX_fxA@mail.gmail.com>

On Sun, 2016-04-03 at 23:07 -0700, Ming Lin wrote:
> On Mon, Mar 28, 2016 at 7:48 AM, Ming Lin <mlin@kernel.org> wrote:
> > On Thu, Mar 24, 2016 at 8:46 AM, James Bottomley
> > <James.Bottomley@hansenpartnership.com> wrote:
> > > On Thu, 2016-03-24 at 08:09 -0700, Ming Lin wrote:
> > > > On Wed, Mar 23, 2016 at 12:40 AM, Christoph Hellwig <hch@lst.de
> > > > >
> > > > wrote:
> > > > > On Tue, Mar 22, 2016 at 03:03:11PM -0700, Ming Lin wrote:
> > > > > > From: Ming Lin <ming.l@ssi.samsung.com>
> > > > > > 
> > > > > > The fist 4 patches make the SG related
> > > > > > definitions/structs/functions
> > > > > > in SCSI code generic and the last patch move it to
> > > > > > lib/sg_pool.c.
> > > > > > 
> > > > > > I still keep the macro "SG_MEMPOOL_NR" since it's used in 3
> > > > > > places.
> > > > > 
> > > > > I don't ѕee the point, but I'm not going to block the series
> > > > > over
> > > > > it either.
> > > > > 
> > > > > The new series looks really nice to me!
> > > > > 
> > > > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > > > 
> > > > Hi James,
> > > > 
> > > > This series touches several sub-systems.
> > > > What's the best way to merge it?
> > > 
> > > It has a minor intrusion into
> > > 
> > >  drivers/ata/pata_icside.c           |   2 +-
> > >  drivers/infiniband/ulp/srp/ib_srp.c |   4 +-
> > >  drivers/usb/storage/scsiglue.c      |   2 +-
> > > 
> > > Apart from that, it's all SCSI, so the SCSI tree would seem to be
> > > the
> > > best one.
> > 
> > Are you OK to merge it?
> 
> Hi James,
> 
> Ping ...
> 
> Are you OK to apply this series?
> Or any changes needed?

It's got the needed reviews, but we need acks from tejun (ATA) and Sagi
(IB) and a repost fixing the test robot objection to patch 5.

James

      reply	other threads:[~2016-04-04 14:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 22:03 [PATCH v2 0/5] mempool based chained scatterlist alloc/free api Ming Lin
2016-03-22 22:03 ` [PATCH v2 1/5] scsi: replace "scsi_data_buffer" with "sg_table" in SG functions Ming Lin
2016-03-22 22:03 ` [PATCH v2 2/5] scsi: replace "mq" with "first_chunk" " Ming Lin
2016-03-22 22:03 ` [PATCH v2 3/5] scsi: rename SG related struct and functions Ming Lin
2016-03-22 22:03 ` [PATCH v2 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS Ming Lin
2016-04-04 14:22   ` Bart Van Assche
2016-04-04 20:24   ` Ming Lin
2016-04-04 21:22     ` Tejun Heo
2016-03-22 22:03 ` [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c Ming Lin
2016-03-23  2:38   ` [PATCH] lib: scatterlist: fix ifnullfree.cocci warnings kbuild test robot
2016-03-23  2:38   ` [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c kbuild test robot
2016-04-04 20:15     ` Ming Lin
2016-04-04 20:17       ` Christoph Hellwig
2016-04-04 20:29         ` Ming Lin
2016-03-23  7:40 ` [PATCH v2 0/5] mempool based chained scatterlist alloc/free api Christoph Hellwig
2016-03-24 15:09   ` Ming Lin
2016-03-24 15:46     ` James Bottomley
2016-03-28 14:48       ` Ming Lin
2016-04-04  6:07         ` Ming Lin
2016-04-04 14:01           ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459778496.2315.1.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mlin@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).