From: Michael Ellerman <mpe@ellerman.id.au>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Balbir Singh <bsingharora@gmail.com>
Cc: linux-kernel@vger.kernel.org, Mark Wielaard <mjw@redhat.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/2] perf probe fixes for ppc64le
Date: Mon, 11 Apr 2016 14:41:46 +1000 [thread overview]
Message-ID: <1460349706.3444.2.camel@ellerman.id.au> (raw)
In-Reply-To: <20160409134239.GL15993@naverao1-tp.in.ibm.com>
On Sat, 2016-04-09 at 19:12 +0530, Naveen N. Rao wrote:
>
> I suppose this boils down to the quirkiness of ABIv2. Though, in
> reality, I don't think most users will notice. As I stated above, users
> will most likely start with the disassembly or debuginfo and this patch
> ensures there are actually no surprises there.
Yeah it's unfortunate that we have to handle these two cases differently.
But I think you've chosen the right trade off.
When we are just given the name we *must not* use the global entry point,
otherwise the probes will often not hit - because most calls go to the local
entry point and skip the global entry point entirely.
When we're given a name and offset, it's less confusing if we use the global
entry point as the base for the offset calculation.
So for the concept:
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
I don't really know this part of the perf code enough to give you an ack for the
actual changes, I'll leave that to the perf maintainers.
cheers
next prev parent reply other threads:[~2016-04-11 4:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 12:32 [PATCH 0/2] perf probe fixes for ppc64le Naveen N. Rao
2016-04-06 12:32 ` [PATCH 1/2] perf/powerpc: Fix kprobe and kretprobe handling with kallsyms Naveen N. Rao
2016-04-07 4:30 ` Ananth N Mavinakayanahalli
2016-04-07 6:32 ` Naveen N. Rao
2016-04-06 12:32 ` [PATCH 2/2] tools/perf: Fix kallsyms perf test on ppc64le Naveen N. Rao
2016-04-06 14:32 ` Ananth N Mavinakayanahalli
2016-04-07 8:19 ` [PATCH 0/2] perf probe fixes for ppc64le Balbir Singh
2016-04-07 9:26 ` Naveen N. Rao
2016-04-08 6:57 ` Balbir Singh
2016-04-09 13:42 ` Naveen N. Rao
2016-04-11 4:41 ` Michael Ellerman [this message]
2016-04-11 13:43 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460349706.3444.2.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=acme@redhat.com \
--cc=bauerman@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhiramat@kernel.org \
--cc=mjw@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).