linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Scott Branden <sbranden@broadcom.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Ray Jui <rjui@broadcom.com>, Will Deacon <will.deacon@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	open list <linux-kernel@vger.kernel.org>,
	Eric Anholt <eric@anholt.net>, Rob Herring <robh+dt@kernel.org>,
	"open list:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." 
	<bcm-kernel-feedback-list@broadcom.com>,
	Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v2 7/9] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.
Date: Fri, 03 Jun 2016 10:45:46 +0200	[thread overview]
Message-ID: <1464943546.24775.131.camel@redhat.com> (raw)
In-Reply-To: <5490184.9quKRk1Imx@wuerfel>

On Fr, 2016-06-03 at 09:38 +0200, Arnd Bergmann wrote:
> On Friday, June 3, 2016 8:18:26 AM CEST Gerd Hoffmann wrote:
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 06b6c2d..71e2d36 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -66,7 +66,8 @@ dtb-$(CONFIG_ARCH_BCM2835) += \
> >         bcm2835-rpi-b-rev2.dtb \
> >         bcm2835-rpi-b-plus.dtb \
> >         bcm2835-rpi-a-plus.dtb \
> > -       bcm2836-rpi-2-b.dtb
> > +       bcm2836-rpi-2-b.dtb \
> > +       ../../../arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dtb
> >  dtb-$(CONFIG_ARCH_BCM_5301X) += \
> >         bcm4708-asus-rt-ac56u.dtb \
> >         bcm4708-asus-rt-ac68u.dtb \
> 
> Let's make this hunk a separate patch so we can discuss it on its
> own.

Hmm, I through we where in agreement to do it this way ...

> I'm not really happy about the way it looks (in general, using ../../../
> anywhere in the kernel looks hacky.
> 
> How about a separate
> 
> dtb-$(CONFIG_ARCH_BCM2835) +=
> 	../../../arm64/boot/dts/broadcom/

Not working.

Tried "subdir-$(CONFIG_ARCH_BCM) += ...".  Didn't work either.
Same for "dts-dirs += ...".

Running out of ideas.  Guess I have to leave this to someone who knows
kbuild better than me.

cheers,
  Gerd

  reply	other threads:[~2016-06-03  8:45 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1464934708-24769-1-git-send-email-kraxel@redhat.com>
2016-06-03  6:18 ` [PATCH v2 1/9] pinctrl: walk into bcm subdir unconditionally Gerd Hoffmann
2016-06-08  8:12   ` Linus Walleij
2016-06-10  0:16     ` Eric Anholt
2016-06-13  7:26   ` Linus Walleij
2016-06-14 17:37     ` Eric Anholt
2016-06-03  6:18 ` [PATCH v2 2/9] irqchip: bcm2835: Avoid arch/arm-specific handle_IRQ Gerd Hoffmann
2016-06-03  6:18 ` [PATCH v2 3/9] arm64: Allow for different DMA and CPU bus offsets Gerd Hoffmann
2016-06-03  6:18 ` [PATCH v2 4/9] arm64: Add platform selection for BCM2835 Gerd Hoffmann
2016-06-03 11:27   ` Catalin Marinas
2016-06-04 19:55     ` Eric Anholt
2016-06-08  9:12       ` Catalin Marinas
2016-06-10  0:21         ` Eric Anholt
2016-06-10  9:56           ` Catalin Marinas
2016-06-15  6:48             ` Eric Anholt
2016-06-15  8:07               ` Catalin Marinas
2016-06-15 21:57                 ` Eric Anholt
2016-06-03  6:18 ` [PATCH v2 5/9] arm64: Add BCM2835 support to the defconfig Gerd Hoffmann
2016-06-03  7:36   ` Arnd Bergmann
2016-06-03  8:50     ` Gerd Hoffmann
2016-06-03  8:58       ` Arnd Bergmann
2016-06-03  9:53     ` Gerd Hoffmann
2016-06-07 22:16     ` Eric Anholt
2016-06-03  6:18 ` [PATCH v2 6/9] dt-bindings: Add root properties for Raspberry Pi 3 Gerd Hoffmann
2016-06-03  6:18 ` [PATCH v2 7/9] ARM: bcm2835: Add devicetree for the " Gerd Hoffmann
2016-06-03  7:38   ` Arnd Bergmann
2016-06-03  8:45     ` Gerd Hoffmann [this message]
2016-06-03  8:55       ` Arnd Bergmann
2016-06-03 10:39         ` Gerd Hoffmann
2016-06-03 11:15           ` Arnd Bergmann
2016-06-03 16:17           ` Rob Herring
2016-06-04 21:39             ` Arnd Bergmann
2016-06-06  7:20             ` Gerd Hoffmann
2016-06-06  7:28               ` Arnd Bergmann
2016-06-06  7:47                 ` Gerd Hoffmann
2016-06-03  9:04   ` Stefan Wahren
2016-06-03  6:18 ` [PATCH v2 8/9] ARM: bcm2835: dt: Add the ethernet to the device trees Gerd Hoffmann
2016-06-03  6:18 ` [PATCH v2 9/9] ARM: bcm2837: " Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464943546.24775.131.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eric@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).