From: Markus Mayer <mmayer@broadcom.com>
To: Nicholas Bellinger <nab@linux-iscsi.org>,
Roland Dreier <roland@purestorage.com>,
Varun Prakash <varun@chelsio.com>
Cc: Markus Mayer <mmayer@broadcom.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()
Date: Fri, 8 Jul 2016 15:43:12 -0700 [thread overview]
Message-ID: <1468017794-4818-6-git-send-email-mmayer@broadcom.com> (raw)
In-Reply-To: <1468017794-4818-1-git-send-email-mmayer@broadcom.com>
After introducing generic strtolower(), iscsi_initiatorname_tolower() is
no longer needed.
Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---
drivers/target/iscsi/iscsi_target_nego.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 89d34bd..fa20638 100644
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -987,21 +987,6 @@ static int iscsi_target_do_login(struct iscsi_conn *conn, struct iscsi_login *lo
return 0;
}
-static void iscsi_initiatorname_tolower(
- char *param_buf)
-{
- char *c;
- u32 iqn_size = strlen(param_buf), i;
-
- for (i = 0; i < iqn_size; i++) {
- c = ¶m_buf[i];
- if (!isupper(*c))
- continue;
-
- *c = tolower(*c);
- }
-}
-
/*
* Processes the first Login Request..
*/
@@ -1075,7 +1060,7 @@ int iscsi_target_locate_portal(
* RFC-3720 3.2.6.1. section c) that says that iSCSI IQNs
* are NOT case sensitive.
*/
- iscsi_initiatorname_tolower(i_buf);
+ strtolower(i_buf);
if (!s_buf) {
if (!login->leading_connection)
--
2.7.4
next prev parent reply other threads:[~2016-07-08 22:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 22:43 [PATCH v3 0/7] lib: string: add functions to case-convert strings Markus Mayer
2016-07-08 22:43 ` [PATCH v3 1/7] " Markus Mayer
2016-07-09 12:04 ` Luis de Bethencourt
2016-07-09 15:30 ` Markus Mayer
2016-07-11 22:46 ` Markus Mayer
2016-07-13 17:19 ` Luis de Bethencourt
2016-07-13 22:26 ` Markus Mayer
2016-07-13 22:53 ` Luis de Bethencourt
2016-07-13 23:04 ` Markus Mayer
2016-07-08 22:43 ` [PATCH v3 2/7] drm/nouveau/core: make use of new strlcpytolower() function Markus Mayer
2016-07-08 22:43 ` [PATCH v3 3/7] ACPI / device_sysfs: make use of new strtolower() function Markus Mayer
2016-07-08 23:22 ` Rafael J. Wysocki
2016-07-08 22:43 ` [PATCH v3 4/7] staging: speakup: replace spk_strlwr() with strlcpytolower() Markus Mayer
2016-07-13 20:57 ` Samuel Thibault
2016-07-08 22:43 ` Markus Mayer [this message]
2016-07-20 21:16 ` [PATCH v3 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower() Nicholas A. Bellinger
2016-07-20 21:17 ` Nicholas A. Bellinger
2016-07-20 21:19 ` Markus Mayer
2016-07-08 22:43 ` [PATCH v3 6/7] drm/nouveau/fifo/gk104: make use of new strcpytoupper() function Markus Mayer
2016-07-08 22:43 ` [PATCH v3 7/7] power_supply: " Markus Mayer
2016-07-10 3:13 ` [PATCH v3 0/7] lib: string: add functions to case-convert strings Chris Metcalf
2016-07-10 4:11 ` Markus Mayer
2016-07-13 22:52 ` Markus Mayer
2016-07-20 20:28 ` Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468017794-4818-6-git-send-email-mmayer@broadcom.com \
--to=mmayer@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).