From: Oliver Neukum <oneukum@suse.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv13 2/3] usb: USB Type-C connector class
Date: Wed, 07 Dec 2016 10:46:48 +0100 [thread overview]
Message-ID: <1481104008.1960.3.camel@suse.com> (raw)
In-Reply-To: <20161202180439.GA25991@roeck-us.net>
On Fri, 2016-12-02 at 10:04 -0800, Guenter Roeck wrote:
Hi,
> At least for my part I very much concentrated on making sure that
> the user space ABI as well as the port driver API are sane and usable.
Rightly so, as this part cannot be changed once included in a kernel
release.
So, can we agree that that part at least is ready to go?
> The driver interface is not my area of expertise. As such, my testing
> and understanding of that part was limited to "it appears to work,
> it must be ok". I very much relied on you to get this part right.
>
> That makes me feel really bad. It isn't fun to have my "Reviewed-by"
> on a patch that gets (and apparently deserves) a WTF from a senior
> kernel maintainer. This hurts both your and my reputation, and obviously
> will make me quite hesitant to add a "Reviewed-by:" to the next version
> of the series.
The driver model is arcane. It is the reason we have people who really
understand it review code.
But I think it is a reason we need to question assumptions.
Is it really true that the lifetimes of both ends of a plug
are tightly locked? What happens if you unplug a cable
whose ends have different power supplies?
Regards
Oliver
next prev parent reply other threads:[~2016-12-07 9:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 12:21 [PATCHv13 0/3] USB Type-C Connector class Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 1/3] lib/string: add sysfs_match_string helper Heikki Krogerus
2016-12-07 23:54 ` [PATCHv13,1/3] " Guenter Roeck
2016-12-08 7:29 ` Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 2/3] usb: USB Type-C connector class Heikki Krogerus
2016-11-29 16:27 ` Greg KH
2016-11-30 9:19 ` Heikki Krogerus
2016-12-02 18:04 ` Guenter Roeck
2016-12-02 18:22 ` Greg KH
2016-12-07 9:11 ` Heikki Krogerus
2016-12-07 9:46 ` Oliver Neukum [this message]
2016-12-07 12:52 ` Heikki Krogerus
2016-12-15 11:50 ` Heikki Krogerus
2016-12-15 12:06 ` Oliver Neukum
2016-12-15 15:01 ` Guenter Roeck
2016-12-19 14:45 ` [RFC PATCH] " Heikki Krogerus
2016-12-19 17:22 ` Guenter Roeck
2016-12-20 14:23 ` Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481104008.1960.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).