From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v5] vfat: Deduplicate hex2bin()
Date: Mon, 31 Jul 2017 22:39:09 +0300 [thread overview]
Message-ID: <1501529949.29303.314.camel@linux.intel.com> (raw)
In-Reply-To: <877eyov49l.fsf@devron>
On Tue, 2017-08-01 at 03:40 +0900, OGAWA Hirofumi wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>
> > We may use hex2bin() instead of custom approach.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
>
>
> > + fill = hex2bin(hc, ip + 1, 2);
> > + if (fill)
> > + return fill;
>
> This should not use random errno (in this case, it is -1 (EPERM)).
You perhaps missed the side note I put after --- line.
It reflects this change.
>
> > + *op++ = hc[1];
> > + *op++ = hc[0];
>
> Maybe, originally endian bug?
No problem reported. And as you noticed quite ago it is __be16
originally as it goes hi-lo.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-07-31 19:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 14:33 [PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko
2017-07-31 18:40 ` OGAWA Hirofumi
2017-07-31 18:44 ` OGAWA Hirofumi
2017-07-31 19:31 ` Andy Shevchenko
2017-07-31 20:54 ` OGAWA Hirofumi
2017-08-01 12:56 ` Andy Shevchenko
2017-07-31 19:39 ` Andy Shevchenko [this message]
2017-07-31 20:56 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501529949.29303.314.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).