From: Samuel Mendoza-Jonas <sam@mendozajonas.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org
Subject: Re: [PATCH net-next] net/ncsi: Add generic netlink family
Date: Tue, 27 Feb 2018 13:29:41 +1100 [thread overview]
Message-ID: <1519698581.7888.2.camel@mendozajonas.com> (raw)
In-Reply-To: <20180226.113136.1568195044048732904.davem@davemloft.net>
On Mon, 2018-02-26 at 11:31 -0500, David Miller wrote:
> From: Samuel Mendoza-Jonas <sam@mendozajonas.com>
> Date: Fri, 23 Feb 2018 15:15:18 +1100
>
> > + * @NCSI_CMD_SET_INTERFACE: set preferred package and channel combination.
> > + * Requires NCSI_ATTR_IFINDEX and the preferred NCSI_ATTR_PACKAGE_ID and
> > + * optionally the preferred NCSI_ATTR_CHANNEL_ID. If neither IDs are
> > + * specified the setting is cleared.
>
> I think clearing the setting when the required attributes are missing
> is dangerous behavior.
>
> It is ambiguous whether the user intended the setting to be cleared,
> or was in error and forgot to supply the attribute due to a bug.
Fair point - I'll change this to be an error and add a separate command
to clear the setting explicitly.
In that vein is having NCSI_ATTR_CHANNEL_ID as an optional parameter
ambiguous enough to justify a separate command as well?
Regards,
Sam
prev parent reply other threads:[~2018-02-27 2:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 4:15 [PATCH net-next] net/ncsi: Add generic netlink family Samuel Mendoza-Jonas
2018-02-26 16:31 ` David Miller
2018-02-27 2:29 ` Samuel Mendoza-Jonas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519698581.7888.2.camel@mendozajonas.com \
--to=sam@mendozajonas.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).