From: Tom Zanussi <zanussi@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] tracing: Fix synthetic event parser
Date: Mon, 22 Oct 2018 15:10:06 -0500 [thread overview]
Message-ID: <1540239006.4393.2.camel@kernel.org> (raw)
In-Reply-To: <153986829702.18251.1286066460999338772.stgit@devbox>
Hi Masami,
Sorry for the late reply on this - was out on vacation last week.
On Thu, 2018-10-18 at 22:11 +0900, Masami Hiramatsu wrote:
> Hi,
>
> Here are 2 fixes for synthetic event parser and its testcase.
> One bug is that the synthetic_events can not accept "unsigned"
> modifier for the field type, and another one is not allowing
> the last independent semicolon.
>
> I found that there is no testcase for checking it too. So the
> last patch in this series adding a testcase for synthetic
> event parser.
>
These patches look good to me, so for the lot:
Acked-by: Tom Zanussi <zanussi@linux.intel.com>
Tested-by: Tom Zanussi <zanussi@linux.intel.com>
Thanks,
Tom
> Thank you,
>
> ---
>
> Masami Hiramatsu (3):
> tracing: Fix synthetic event to accept unsigned modifier
> tracing: Fix synthetic event to allow semicolon at end
> selftests: ftrace: Add synthetic event syntax testcase
>
>
> kernel/trace/trace_events_hist.c | 32 ++++++--
> .../inter-event/trigger-synthetic-event-syntax.tc | 80
> ++++++++++++++++++++
> 2 files changed, 105 insertions(+), 7 deletions(-)
> create mode 100644
> tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-
> synthetic-event-syntax.tc
>
> --
> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
prev parent reply other threads:[~2018-10-22 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 13:11 [PATCH v2 0/3] tracing: Fix synthetic event parser Masami Hiramatsu
2018-10-18 13:12 ` [PATCH v2 1/3] tracing: Fix synthetic event to accept unsigned modifier Masami Hiramatsu
2018-10-18 13:12 ` [PATCH v2 2/3] tracing: Fix synthetic event to allow semicolon at end Masami Hiramatsu
2018-10-18 13:13 ` [PATCH v2 3/3] selftests: ftrace: Add synthetic event syntax testcase Masami Hiramatsu
2018-10-18 20:34 ` Steven Rostedt
2018-10-18 20:38 ` Shuah Khan
2018-10-18 20:45 ` Steven Rostedt
2018-10-19 0:38 ` Masami Hiramatsu
2018-10-19 0:46 ` Steven Rostedt
2018-10-22 20:10 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540239006.4393.2.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).