linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Fabio Estevam <festevam@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Joe Perches <joe@perches.com>
Cc: Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dinh Nguyen <dinguyen@kernel.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: linux-next: Fixes tag needs some work in the clk tree
Date: Fri, 18 Jan 2019 09:37:26 -0800	[thread overview]
Message-ID: <154783304655.169631.12906027462791855701@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <878szi3zp6.fsf@concordia.ellerman.id.au>

Quoting Michael Ellerman (2019-01-18 04:41:41)
> Stephen Boyd <sboyd@kernel.org> writes:
> 
> > Quoting Fabio Estevam (2019-01-16 17:25:21)
> >> On Wed, Jan 16, 2019 at 10:44 PM Stephen Boyd <sboyd@kernel.org> wrote:
> >> 
> >> > Ok sure. Does this matter to scripts? Is it documented in
> >> > Documentation/process/submitting-patches.rst? I've seen both types, one
> >> 
> >> From Documentation/process/submitting-patches.rst"
> >> 
> >> "If your patch fixes a bug in a specific commit, e.g. you found an issue using
> >> ``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
> >> the SHA-1 ID, and the one line summary.  For example::
> >> 
> >> Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")"
> >
> > Yes but 'one line summary' is not clear to me. Does it mean the summary
> > line? Or the one line summary on one line regardless of commit message
> > column wrapping? Sorry to be pedantic but I can see how this can be
> > misunderstood.
> 
> Yeah "one line summary" is referring to the subject of the commit.
> 
> So it doesn't explicitly say not to split it across lines, it probably
> should.
> 
> eg: ?

Yes, thanks!

> 
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 30dc00a364e8..12a283ba3929 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -186,6 +186,8 @@ If your patch fixes a bug in a specific commit, e.g. you found an issue using
>  
>         Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")
>  
> +To ease parsing of the 'Fixes:' tag please don't split it across multiple lines.
> +
>  The following ``git config`` settings can be used to add a pretty format for
>  outputting the above style in the ``git log`` or ``git show`` commands::
>  
> 

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

Do you have a patch for checkpatch too? Maybe Joe can solve my problem.


  parent reply	other threads:[~2019-01-18 17:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 21:34 linux-next: Fixes tag needs some work in the clk tree Stephen Rothwell
2019-01-16 22:35 ` Stephen Boyd
2019-01-17  1:25   ` Fabio Estevam
2019-01-17 18:42     ` Stephen Boyd
2019-01-18 12:41       ` Michael Ellerman
2019-01-18 12:49         ` Fabio Estevam
2019-01-18 17:37         ` Stephen Boyd [this message]
2019-01-18 17:41           ` Nathan Chancellor
2019-01-18 18:36             ` Joe Perches
2019-05-26 10:35 Stephen Rothwell
2020-03-06  6:58 Stephen Rothwell
2020-09-23 11:46 Stephen Rothwell
2020-10-01  0:22 ` Stephen Boyd
2020-10-01  1:22   ` Stephen Rothwell
2020-12-07 22:05 Stephen Rothwell
2020-12-08  8:37 ` Geert Uytterhoeven
2020-12-09 17:29   ` Stephen Boyd
2020-12-10  7:52     ` Geert Uytterhoeven
2020-12-20 21:35       ` Stephen Rothwell
2020-12-21  8:07         ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154783304655.169631.12906027462791855701@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=festevam@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=mturquette@baylibre.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=sboyd@codeaurora.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).