linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Zanussi <zanussi@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: rostedt@goodmis.org, tglx@linutronix.de, namhyung@kernel.org,
	bigeasy@linutronix.de, joel@joelfernandes.org,
	linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v4 07/11] tracing: Remove trigger-extended-error-support testcase
Date: Sat, 23 Mar 2019 08:08:36 -0500	[thread overview]
Message-ID: <1553346516.2307.6.camel@kernel.org> (raw)
In-Reply-To: <20190323191302.321ea1d6b9cb1c75c7e828c7@kernel.org>

Hi Masami,

On Sat, 2019-03-23 at 19:13 +0900, Masami Hiramatsu wrote:
> Hi Tom,
> 
> This should be tagged with "selftests/ftrace:". :)
> 

Yeah, will change that in the next update.

Thanks,

Tom

> Thank you,
> 
> On Fri, 22 Mar 2019 10:34:33 -0500
> Tom Zanussi <zanussi@kernel.org> wrote:
> 
> > From: Tom Zanussi <tom.zanussi@linux.intel.com>
> > 
> > Error handling has been moved to the common tracing/error_log, so
> > this
> > test is no longer valid.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> > ---
> >  .../inter-event/trigger-extended-error-support.tc  | 28 ----------
> > ------------
> >  1 file changed, 28 deletions(-)
> >  delete mode 100644
> > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-
> > extended-error-support.tc
> > 
> > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-
> > event/trigger-extended-error-support.tc
> > b/tools/testing/selftests/ftrace/test.d/trigger/inter-
> > event/trigger-extended-error-support.tc
> > deleted file mode 100644
> > index 9912616a8672..000000000000
> > --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-
> > event/trigger-extended-error-support.tc
> > +++ /dev/null
> > @@ -1,28 +0,0 @@
> > -#!/bin/sh
> > -# SPDX-License-Identifier: GPL-2.0
> > -# description: event trigger - test extended error support
> > -
> > -
> > -fail() { #msg
> > -    echo $1
> > -    exit_fail
> > -}
> > -
> > -if [ ! -f set_event ]; then
> > -    echo "event tracing is not supported"
> > -    exit_unsupported
> > -fi
> > -
> > -if [ ! -f synthetic_events ]; then
> > -    echo "synthetic event is not supported"
> > -    exit_unsupported
> > -fi
> > -
> > -echo "Test extended error support"
> > -echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="ping"' >
> > events/sched/sched_wakeup/trigger
> > -! echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="ping"'
> > >> events/sched/sched_wakeup/trigger 2> /dev/null
> > -if ! grep -q "ERROR:" events/sched/sched_wakeup/hist; then
> > -    fail "Failed to generate extended error in histogram"
> > -fi
> > -
> > -exit 0
> > -- 
> > 2.14.1
> > 
> 
> 

  reply	other threads:[~2019-03-23 13:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 15:34 [PATCH v4 00/11] tracing: common error_log for ftrace Tom Zanussi
2019-03-22 15:34 ` [PATCH v4 01/11] tracing: Add tracing error log Tom Zanussi
2019-03-26  8:22   ` Masami Hiramatsu
2019-03-22 15:34 ` [PATCH v4 02/11] tracing: Save the last hist command's associated event name Tom Zanussi
2019-03-22 15:34 ` [PATCH v4 03/11] tracing: Use tracing error_log with hist triggers Tom Zanussi
2019-03-22 15:34 ` [PATCH v4 04/11] tracing: Use tracing error_log with trace event filters Tom Zanussi
2019-03-25 11:37   ` Namhyung Kim
2019-03-25 14:28     ` Steven Rostedt
2019-03-22 15:34 ` [PATCH v4 05/11] tracing: Use tracing error_log with probe events Tom Zanussi
2019-03-22 15:34 ` [PATCH v4 06/11] selftests/ftrace: Add error_log testcase for probe errors Tom Zanussi
2019-03-23 10:22   ` Masami Hiramatsu
2019-03-23 13:11     ` Tom Zanussi
2019-03-24 10:11       ` Masami Hiramatsu
2019-03-22 15:34 ` [PATCH v4 07/11] tracing: Remove trigger-extended-error-support testcase Tom Zanussi
2019-03-23 10:13   ` Masami Hiramatsu
2019-03-23 13:08     ` Tom Zanussi [this message]
2019-03-22 15:34 ` [PATCH v4 08/11] selftests/ftrace: Add tracing/error_log testcase Tom Zanussi
2019-03-23 12:08   ` Masami Hiramatsu
2019-03-23 13:17     ` Tom Zanussi
2019-03-22 15:34 ` [PATCH v4 09/11] tracing: Add tracing/error_log Documentation Tom Zanussi
2019-03-22 15:34 ` [PATCH v4 10/11] tracing: Add error_log to README Tom Zanussi
2019-03-22 15:34 ` [PATCH v4 11/11] selftests/ftrace: Change stderr redirection for probe error_log testcase Tom Zanussi
2019-03-23 10:28   ` Masami Hiramatsu
2019-03-23 13:14     ` Tom Zanussi
2019-03-23 10:14 ` [PATCH v4 00/11] tracing: common error_log for ftrace Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553346516.2307.6.camel@kernel.org \
    --to=zanussi@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).