From: Qian Cai <cai@lca.pw>
To: Roman Gushchin <guro@fb.com>
Cc: "oleg@redhat.com" <oleg@redhat.com>,
"tj@kernel.org" <tj@kernel.org>,
"lizefan@huawei.com" <lizefan@huawei.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: ptrace warning due to "cgroup: get rid of cgroup_freezer_frozen_exit()"
Date: Wed, 08 May 2019 09:10:21 -0400 [thread overview]
Message-ID: <1557321021.6132.21.camel@lca.pw> (raw)
In-Reply-To: <20190507213752.GA24308@tower.DHCP.thefacebook.com>
On Tue, 2019-05-07 at 21:37 +0000, Roman Gushchin wrote:
> Can you, please, try if the following patch fixes the problem?
It works great.
> --
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 16b72f4f14df..bf2f268f1386 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2484,9 +2484,6 @@ bool get_signal(struct ksignal *ksig)
> sigdelset(¤t->pending.signal, SIGKILL);
> recalc_sigpending();
> current->jobctl &= ~JOBCTL_TRAP_FREEZE;
> - spin_unlock_irq(&sighand->siglock);
> - if (unlikely(cgroup_task_frozen(current)))
> - cgroup_leave_frozen(true);
> goto fatal;
> }
>
> @@ -2608,8 +2605,10 @@ bool get_signal(struct ksignal *ksig)
> continue;
> }
>
> - spin_unlock_irq(&sighand->siglock);
> fatal:
> + spin_unlock_irq(&sighand->siglock);
> + if (unlikely(cgroup_task_frozen(current)))
> + cgroup_leave_frozen(true);
>
> /*
> * Anything else is fatal, maybe with a core dump.
next prev parent reply other threads:[~2019-05-08 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 20:04 ptrace warning due to "cgroup: get rid of cgroup_freezer_frozen_exit()" Qian Cai
2019-05-07 21:37 ` Roman Gushchin
2019-05-08 13:10 ` Qian Cai [this message]
2019-05-08 15:25 ` Oleg Nesterov
2019-05-08 18:03 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557321021.6132.21.camel@lca.pw \
--to=cai@lca.pw \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).