From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FD23C04AB4 for ; Fri, 17 May 2019 08:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0954B20818 for ; Fri, 17 May 2019 08:35:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728469AbfEQIfm convert rfc822-to-8bit (ORCPT ); Fri, 17 May 2019 04:35:42 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:64206 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727065AbfEQIfl (ORCPT ); Fri, 17 May 2019 04:35:41 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 16585171-1500050 for multiple; Fri, 17 May 2019 09:35:12 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Jani Nikula , linux-kbuild@vger.kernel.org From: Chris Wilson In-Reply-To: <20190516194818.29230-1-jani.nikula@intel.com> Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, jani.nikula@intel.com, Masahiro Yamada , Michal Marek References: <20190516194818.29230-1-jani.nikula@intel.com> Message-ID: <155808211071.12244.10320883277188429270@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [RFC 1/3] kbuild: add support for ensuring headers are self-contained Date: Fri, 17 May 2019 09:35:10 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jani Nikula (2019-05-16 20:48:16) > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 8a1f64f17740..c2839de06485 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -66,6 +66,9 @@ extra-y += $(patsubst %.dtb,%.dt.yaml, $(dtb-y)) > extra-$(CONFIG_OF_ALL_DTBS) += $(patsubst %.dtb,%.dt.yaml, $(dtb-)) > endif > > +# Test self-contained headers > +extra-$(CONFIG_HEADER_TEST) += $(patsubst %.h,%.header_test.o,$(header-test-y)) This didn't get pulled into clean-files. clean-files-$(CONFIG_HEADER_TEST) += $(patsubst %.h,%.header_test.c,$(header-test-y)) ? Not enough. Nor is clean-files-y +=... And it should also be put into the global gitignore I think. -Chris