From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alexey Dobriyan <adobriyan@gmail.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
axboe@kernel.dk, kvalo@codeaurora.org,
john.johansen@canonical.com, linux-arch@vger.kernel.org
Subject: Re: [PATCH] unaligned: delete 1-byte accessors
Date: Mon, 22 Jul 2019 08:08:33 +0900 [thread overview]
Message-ID: <1563750513.2898.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <20190721215253.GA18177@avx2>
On Mon, 2019-07-22 at 00:52 +0300, Alexey Dobriyan wrote:
> Each and every 1-byte access is aligned!
The design idea of this is for parsing descriptors. We simply chunk up
the describing structure using get_unaligned for everything. The
reason is because a lot of these structures come with reserved areas
which we may make use of later. If we're using get_unaligned for
everything we can simply change a u8 to a u16 in the structure
absorbing the reserved padding. With your change now I'd have to chase
down every byte access and replace it with get_unaligned instead of
simply changing the structure.
What's the significant advantage of this change that compensates for
the problems the above causes?
James
next prev parent reply other threads:[~2019-07-21 23:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 21:52 [PATCH] unaligned: delete 1-byte accessors Alexey Dobriyan
2019-07-21 23:08 ` James Bottomley [this message]
2019-07-22 5:22 ` Alexey Dobriyan
2019-07-22 5:48 ` James Bottomley
2019-07-22 6:07 ` Alexey Dobriyan
2019-07-22 6:20 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563750513.2898.4.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=john.johansen@canonical.com \
--cc=kvalo@codeaurora.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).