From: Chris Wilson <chris@chris-wilson.co.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Martin Wilck <Martin.Wilck@suse.com>
Cc: Michal Koutny <MKoutny@suse.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"leho@kraav.com" <leho@kraav.com>,
"tiwai@suse.de" <tiwai@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 5.3-rc3: Frozen graphics with kcompactd migrating i915 pages
Date: Thu, 12 Sep 2019 13:47:48 +0100 [thread overview]
Message-ID: <156829246802.4926.7844021009098193103@skylake-alporthouse-com> (raw)
In-Reply-To: <CAHk-=wjKv_Zw2zGHduyrQH_VQzxXYzwKdwwzzpsdnsdx=EK30Q@mail.gmail.com>
Quoting Linus Torvalds (2019-09-12 12:59:25)
> On Thu, Sep 12, 2019 at 12:51 PM Martin Wilck <Martin.Wilck@suse.com> wrote:
> >
> > Is there an alternative to reverting aa56a292ce62 ("drm/i915/userptr:
> > Acquire the page lock around set_page_dirty()")? And if we do, what
> > would be the consequences? Would other patches need to be reverted,
> > too?
>
> Looking at that commit, and the backtrace of the lockup, I think that
> reverting it is the correct thing to do.
>
> You can't take the page lock in invalidate_range(), since it's called
> from try_to_unmap(), which is called with the page lock already held.
>
> So commit aa56a292ce62 is just fundamentally completely wrong and
> should be reverted.
There's still the dilemma that we get called without the page lock, but
at this moment in time in order to hit 5.3, it needs a revert sent
directly to Linus.
-Chris
next prev parent reply other threads:[~2019-09-12 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 12:41 5.3-rc3: Frozen graphics with kcompactd migrating i915 pages Martin Wilck
2019-08-09 12:53 ` Chris Wilson
2019-09-10 14:20 ` Leho Kraav
2019-09-12 11:23 ` Martin Wilck
2019-09-12 11:58 ` leho
2019-09-12 11:59 ` Linus Torvalds
2019-09-12 12:47 ` Chris Wilson [this message]
2019-09-12 12:56 ` [PATCH] Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()" Chris Wilson
2019-09-12 14:39 ` [Intel-gfx] " Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156829246802.4926.7844021009098193103@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=MKoutny@suse.com \
--cc=Martin.Wilck@suse.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=leho@kraav.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).