From: Mimi Zohar <zohar@linux.ibm.com>
To: Tushar Sugandhi <tusharsu@linux.microsoft.com>,
joe@perches.com, skhan@linuxfoundation.org,
linux-integrity@vger.kernel.org
Cc: sashal@kernel.org, nramas@linux.microsoft.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] IMA: improve log messages in IMA
Date: Wed, 12 Feb 2020 10:23:29 -0500 [thread overview]
Message-ID: <1581521009.8515.72.camel@linux.ibm.com> (raw)
In-Reply-To: <20200211231414.6640-1-tusharsu@linux.microsoft.com>
Hi Tushar,
"in IMA" is redundant in the above Subject line.
On Tue, 2020-02-11 at 15:14 -0800, Tushar Sugandhi wrote:
> Some files under IMA prefix the log statement with the respective file
> names and not with the string "ima". This is not consistent with the rest
> of the IMA files.
>
> The function process_buffer_measurement() does not have log messages for
> failure conditions.
>
> The #define for formatting log messages, pr_fmt, is duplicated in the
> files under security/integrity.
>
> This patchset addresses the above issues.
The cover letter should provide a summary of the problem(s) being
addressed by the individual patches, not a repetition of the
individual patch descriptions.
Mimi
>
> Tushar Sugandhi (3):
> add log prefix to ima_mok.c, ima_asymmetric_keys.c, ima_queue_keys.c
> add log message to process_buffer_measurement failure conditions
> add module name and base name prefix to log statements
>
> security/integrity/digsig.c | 2 --
> security/integrity/digsig_asymmetric.c | 2 --
> security/integrity/evm/evm_crypto.c | 2 --
> security/integrity/evm/evm_main.c | 2 --
> security/integrity/evm/evm_secfs.c | 2 --
> security/integrity/ima/Makefile | 6 +++---
> security/integrity/ima/ima_asymmetric_keys.c | 2 --
> security/integrity/ima/ima_crypto.c | 2 --
> security/integrity/ima/ima_fs.c | 2 --
> security/integrity/ima/ima_init.c | 2 --
> security/integrity/ima/ima_kexec.c | 1 -
> security/integrity/ima/ima_main.c | 5 +++--
> security/integrity/ima/ima_policy.c | 2 --
> security/integrity/ima/ima_queue.c | 2 --
> security/integrity/ima/ima_queue_keys.c | 2 --
> security/integrity/ima/ima_template.c | 2 --
> security/integrity/ima/ima_template_lib.c | 2 --
> security/integrity/integrity.h | 6 ++++++
> 18 files changed, 12 insertions(+), 34 deletions(-)
>
next prev parent reply other threads:[~2020-02-12 15:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 23:14 [PATCH v3 0/3] IMA: improve log messages in IMA Tushar Sugandhi
2020-02-11 23:14 ` [PATCH v3 1/3] IMA: Update KBUILD_MODNAME for IMA files to ima Tushar Sugandhi
2020-02-12 14:49 ` Mimi Zohar
2020-02-12 22:25 ` Tushar Sugandhi
2020-02-11 23:14 ` [PATCH v3 2/3] IMA: Add log statements for failure conditions Tushar Sugandhi
2020-02-12 14:47 ` Mimi Zohar
2020-02-12 22:30 ` Tushar Sugandhi
2020-02-13 0:21 ` Mimi Zohar
2020-02-13 21:01 ` Tushar Sugandhi
2020-02-11 23:14 ` [PATCH v3 3/3] IMA: Add module name and base name prefix to log Tushar Sugandhi
2020-02-12 14:29 ` Mimi Zohar
2020-02-12 15:26 ` James Bottomley
2020-02-12 15:47 ` Joe Perches
2020-02-12 22:52 ` Shuah Khan
2020-02-13 0:38 ` Mimi Zohar
2020-02-13 0:56 ` Tushar Sugandhi
2020-02-12 15:23 ` Mimi Zohar [this message]
2020-02-12 22:22 ` [PATCH v3 0/3] IMA: improve log messages in IMA Tushar Sugandhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581521009.8515.72.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=joe@perches.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tusharsu@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).