From: CK Hu <ck.hu@mediatek.com>
To: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <wsd_upstream@mediatek.com>,
Bibby Hsieh <bibby.hsieh@mediatek.com>,
Houlong Wei <houlong.wei@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<srv_heupstream@mediatek.com>,
"Ming-Fan Chen" <ming-fan.chen@mediatek.com>
Subject: Re: [PATCH v3 11/13] soc: mediatek: cmdq: add jump function
Date: Fri, 28 Feb 2020 22:59:41 +0800 [thread overview]
Message-ID: <1582901981.14824.9.camel@mtksdaap41> (raw)
In-Reply-To: <1582897461-15105-13-git-send-email-dennis-yc.hsieh@mediatek.com>
Hi, Dennis:
On Fri, 2020-02-28 at 21:44 +0800, Dennis YC Hsieh wrote:
> Add jump function so that client can jump to any address which
> contains instruction.
>
> Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-cmdq-helper.c | 12 ++++++++++++
> include/linux/soc/mediatek/mtk-cmdq.h | 11 +++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 58fec634dcf1..bbc68a7c81e9 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -372,6 +372,18 @@ int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value)
> }
> EXPORT_SYMBOL(cmdq_pkt_assign);
>
> +int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr)
> +{
> + struct cmdq_client *cl = pkt->cl;
> + struct cmdq_instruction inst = { {0} };
> +
> + inst.op = CMDQ_CODE_JUMP;
> + inst.offset = 1;
Symbolize the value '1'.
> + inst.value = addr >> cmdq_mbox_shift(cl->chan);
If you write as 'cmdq_mbox_shift(pkt->cl->chan)', you could drop local
variable 'cl'.
Regards,
CK
> + return cmdq_pkt_append_command(pkt, inst);
> +}
> +EXPORT_SYMBOL(cmdq_pkt_jump);
> +
> int cmdq_pkt_finalize(struct cmdq_pkt *pkt)
> {
> struct cmdq_instruction inst = { {0} };
> diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h
> index 99e77155f967..1a6c56f3bec1 100644
> --- a/include/linux/soc/mediatek/mtk-cmdq.h
> +++ b/include/linux/soc/mediatek/mtk-cmdq.h
> @@ -213,6 +213,17 @@ int cmdq_pkt_poll_mask(struct cmdq_pkt *pkt, u8 subsys,
> */
> int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value);
>
> +/**
> + * cmdq_pkt_jump() - Append jump command to the CMDQ packet, ask GCE
> + * to execute an instruction that change current thread PC to
> + * a physical address which should contains more instruction.
> + * @pkt: the CMDQ packet
> + * @addr: physical address of target instruction buffer
> + *
> + * Return: 0 for success; else the error code is returned
> + */
> +int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr);
> +
> /**
> * cmdq_pkt_finalize() - Append EOC and jump command to pkt.
> * @pkt: the CMDQ packet
next prev parent reply other threads:[~2020-02-28 14:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 13:44 [PATCH v3 00/13] support gce on mt6779 platform Dennis YC Hsieh
2020-02-28 13:44 ` Dennis YC Hsieh
2020-02-28 13:44 ` [PATCH v3 01/13] dt-binding: gce: add gce header file for mt6779 Dennis YC Hsieh
2020-02-28 15:26 ` CK Hu
2020-03-02 20:15 ` Rob Herring
2020-02-28 13:44 ` [PATCH v3 02/13] mailbox: cmdq: variablize address shift in platform Dennis YC Hsieh
2020-02-28 15:22 ` CK Hu
2020-02-29 13:36 ` Dennis-YC Hsieh
2020-02-28 13:44 ` [PATCH v3 03/13] mailbox: cmdq: support mt6779 gce platform definition Dennis YC Hsieh
2020-02-28 13:44 ` [PATCH v3 04/13] mailbox: mediatek: cmdq: clear task in channel before shutdown Dennis YC Hsieh
2020-02-28 15:57 ` CK Hu
2020-02-29 13:40 ` Dennis-YC Hsieh
2020-02-28 13:44 ` [PATCH v3 05/13] soc: mediatek: cmdq: return send msg error code Dennis YC Hsieh
2020-02-28 15:39 ` CK Hu
2020-02-29 13:41 ` Dennis-YC Hsieh
2020-02-28 13:44 ` [PATCH v3 06/13] soc: mediatek: cmdq: add assign function Dennis YC Hsieh
2020-02-28 14:44 ` CK Hu
2020-02-28 13:44 ` [PATCH v3 07/13] soc: mediatek: cmdq: add write_s function Dennis YC Hsieh
2020-02-28 14:49 ` CK Hu
2020-02-28 13:44 ` [PATCH v3 08/13] soc: mediatek: cmdq: add read_s function Dennis YC Hsieh
2020-02-28 14:50 ` CK Hu
2020-02-28 13:44 ` [PATCH v3 09/13] soc: mediatek: cmdq: add write_s value function Dennis YC Hsieh
2020-02-28 14:55 ` CK Hu
2020-02-28 13:44 ` [PATCH v3 10/13] soc: mediatek: cmdq: export finalize function Dennis YC Hsieh
2020-02-28 13:44 ` [PATCH v3 11/13] soc: mediatek: cmdq: add jump function Dennis YC Hsieh
2020-02-28 14:59 ` CK Hu [this message]
2020-02-29 13:42 ` Dennis-YC Hsieh
2020-02-28 13:44 ` [PATCH v3 12/13] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api Dennis YC Hsieh
2020-02-28 14:32 ` CK Hu
2020-02-29 14:37 ` Dennis-YC Hsieh
2020-02-28 13:44 ` [PATCH v3 13/13] soc: mediatek: cmdq: add set event function Dennis YC Hsieh
2020-02-28 15:05 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582901981.14824.9.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=bibby.hsieh@mediatek.com \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ming-fan.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).