From: Li Bin <huawei.libin@huawei.com>
To: <acme@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <liwei391@huawei.com>, <xiexiuqi@huawei.com>, <huawei.libin@huawei.com>
Subject: [PATCH] perf svghelper: fix memory leak in svg_build_topology_map
Date: Wed, 3 Jun 2020 11:00:58 +0800 [thread overview]
Message-ID: <1591153258-59840-1-git-send-email-huawei.libin@huawei.com> (raw)
Fix leak of memory pointed to by t.sib_thr and t.sib_core in
svg_build_topology_map in the non-error path.
Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
tools/perf/util/svghelper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c
index 96f941e..d50955f 100644
--- a/tools/perf/util/svghelper.c
+++ b/tools/perf/util/svghelper.c
@@ -754,6 +754,7 @@ int svg_build_topology_map(struct perf_env *env)
int i, nr_cpus;
struct topology t;
char *sib_core, *sib_thr;
+ int ret = -1;
nr_cpus = min(env->nr_cpus_online, MAX_NR_CPUS);
@@ -798,12 +799,11 @@ int svg_build_topology_map(struct perf_env *env)
topology_map[i] = -1;
scan_core_topology(topology_map, &t, nr_cpus);
-
- return 0;
+ ret = 0;
exit:
zfree(&t.sib_core);
zfree(&t.sib_thr);
- return -1;
+ return ret;
}
--
1.7.12.4
reply other threads:[~2020-06-03 3:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591153258-59840-1-git-send-email-huawei.libin@huawei.com \
--to=huawei.libin@huawei.com \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).