From: Majd Dibbiny <majd@mellanox.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Doug Ledford <dledford@redhat.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
"Leon Romanovsky" <leonro@mellanox.com>,
Matan Barak <matanb@mellanox.com>,
"Sean Hefty" <sean.hefty@intel.com>,
Yishai Hadas <yishaih@mellanox.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 12/29] IB/mlx4: Enclose 17 expressions for the sizeof operator by parentheses
Date: Sun, 19 Feb 2017 17:21:53 +0000 [thread overview]
Message-ID: <15CAFA80-3F81-4FF3-90A6-F215FF69FD33@mellanox.com> (raw)
In-Reply-To: <9ba34d2d-1d54-4f65-4c01-152c72b624b4@users.sourceforge.net>
> On Feb 18, 2017, at 11:02 PM, SF Markus Elfring <elfring@users.sourceforge.net> wrote:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 18 Feb 2017 11:28:41 +0100
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: sizeof … should be sizeof(…)
>
> Thus fix the affected source code places.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/infiniband/hw/mlx4/main.c | 35 +++++++++++++++++------------------
> 1 file changed, 17 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
> index 350c9148340e..b3b5ded85166 100644
> --- a/drivers/infiniband/hw/mlx4/main.c
> +++ b/drivers/infiniband/hw/mlx4/main.c
> @@ -457,8 +457,8 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
>
> resp.response_length = offsetof(typeof(resp), response_length) +
> sizeof(resp.response_length);
> - in_mad = kzalloc(sizeof *in_mad, GFP_KERNEL);
> - out_mad = kmalloc(sizeof *out_mad, GFP_KERNEL);
> + in_mad = kzalloc(sizeof(*in_mad), GFP_KERNEL);
> + out_mad = kmalloc(sizeof(*out_mad), GFP_KERNEL);
> err = -ENOMEM;
> if (!in_mad || !out_mad)
> goto out;
> @@ -471,8 +471,7 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
> if (err)
> goto out;
>
> - memset(props, 0, sizeof *props);
> -
> + memset(props, 0, sizeof(*props));
> have_ib_ports = num_ib_ports(dev->dev);
>
> props->fw_ver = dev->dev->caps.fw_ver;
> @@ -595,8 +594,8 @@ static int ib_link_query_port(struct ib_device *ibdev, u8 port,
> int mad_ifc_flags = MLX4_MAD_IFC_IGNORE_KEYS;
> int err = -ENOMEM;
>
> - in_mad = kzalloc(sizeof *in_mad, GFP_KERNEL);
> - out_mad = kmalloc(sizeof *out_mad, GFP_KERNEL);
> + in_mad = kzalloc(sizeof(*in_mad), GFP_KERNEL);
> + out_mad = kmalloc(sizeof(*out_mad), GFP_KERNEL);
> if (!in_mad || !out_mad)
> goto out;
>
> @@ -771,8 +770,8 @@ int __mlx4_ib_query_gid(struct ib_device *ibdev, u8 port, int index,
> int clear = 0;
> int mad_ifc_flags = MLX4_MAD_IFC_IGNORE_KEYS;
>
> - in_mad = kzalloc(sizeof *in_mad, GFP_KERNEL);
> - out_mad = kmalloc(sizeof *out_mad, GFP_KERNEL);
> + in_mad = kzalloc(sizeof(*in_mad), GFP_KERNEL);
> + out_mad = kmalloc(sizeof(*out_mad), GFP_KERNEL);
> if (!in_mad || !out_mad)
> goto out;
>
> @@ -908,8 +907,8 @@ int __mlx4_ib_query_pkey(struct ib_device *ibdev, u8 port, u16 index,
> int mad_ifc_flags = MLX4_MAD_IFC_IGNORE_KEYS;
> int err = -ENOMEM;
>
> - in_mad = kzalloc(sizeof *in_mad, GFP_KERNEL);
> - out_mad = kmalloc(sizeof *out_mad, GFP_KERNEL);
> + in_mad = kzalloc(sizeof(*in_mad), GFP_KERNEL);
> + out_mad = kmalloc(sizeof(*out_mad), GFP_KERNEL);
> if (!in_mad || !out_mad)
> goto out;
>
> @@ -1280,7 +1279,7 @@ static struct ib_pd *mlx4_ib_alloc_pd(struct ib_device *ibdev,
> struct mlx4_ib_pd *pd;
> int err;
>
> - pd = kmalloc(sizeof *pd, GFP_KERNEL);
> + pd = kmalloc(sizeof(*pd), GFP_KERNEL);
> if (!pd)
> return ERR_PTR(-ENOMEM);
>
> @@ -1319,7 +1318,7 @@ static struct ib_xrcd *mlx4_ib_alloc_xrcd(struct ib_device *ibdev,
> if (!(to_mdev(ibdev)->dev->caps.flags & MLX4_DEV_CAP_FLAG_XRC))
> return ERR_PTR(-ENOSYS);
>
> - xrcd = kmalloc(sizeof *xrcd, GFP_KERNEL);
> + xrcd = kmalloc(sizeof(*xrcd), GFP_KERNEL);
> if (!xrcd)
> return ERR_PTR(-ENOMEM);
>
> @@ -1367,7 +1366,7 @@ static int add_gid_entry(struct ib_qp *ibqp, union ib_gid *gid)
> struct mlx4_ib_dev *mdev = to_mdev(ibqp->device);
> struct mlx4_ib_gid_entry *ge;
>
> - ge = kzalloc(sizeof *ge, GFP_KERNEL);
> + ge = kzalloc(sizeof(*ge), GFP_KERNEL);
> if (!ge)
> return -ENOMEM;
>
> @@ -2089,8 +2088,8 @@ static int init_node_data(struct mlx4_ib_dev *dev)
> int mad_ifc_flags = MLX4_MAD_IFC_IGNORE_KEYS;
> int err = -ENOMEM;
>
> - in_mad = kzalloc(sizeof *in_mad, GFP_KERNEL);
> - out_mad = kmalloc(sizeof *out_mad, GFP_KERNEL);
> + in_mad = kzalloc(sizeof(*in_mad), GFP_KERNEL);
> + out_mad = kmalloc(sizeof(*out_mad), GFP_KERNEL);
> if (!in_mad || !out_mad)
> goto out;
>
> @@ -2600,7 +2599,7 @@ static void *mlx4_ib_add(struct mlx4_dev *dev)
> if (num_ports == 0)
> return NULL;
>
> - ibdev = (struct mlx4_ib_dev *) ib_alloc_device(sizeof *ibdev);
> + ibdev = (struct mlx4_ib_dev *) ib_alloc_device(sizeof(*ibdev));
> if (!ibdev) {
> dev_err(&dev->persist->pdev->dev,
> "Device struct alloc failed\n");
> @@ -3301,12 +3300,12 @@ static void mlx4_ib_event(struct mlx4_dev *dev, void *ibdev_ptr,
> break;
>
> case MLX4_DEV_EVENT_PORT_MGMT_CHANGE:
> - ew = kmalloc(sizeof *ew, GFP_ATOMIC);
> + ew = kmalloc(sizeof(*ew), GFP_ATOMIC);
> if (!ew)
> break;
>
> INIT_WORK(&ew->work, handle_port_mgmt_change_event);
> - memcpy(&ew->ib_eqe, eqe, sizeof *eqe);
> + memcpy(&ew->ib_eqe, eqe, sizeof(*eqe));
> ew->ib_dev = ibdev;
> /* need to queue only for port owner, which uses GEN_EQE */
> if (mlx4_is_master(dev))
> --
> 2.11.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
Reviewed-by: Majd Dibbiny
<majd@mellanox.com>
next prev parent reply other threads:[~2017-02-19 17:22 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 20:45 [PATCH 00/29] IB/mlx: Fine-tuning for several function implementations SF Markus Elfring
2017-02-18 20:47 ` [PATCH 01/29] IB/mlx4: Use kcalloc() in mlx4_ib_alloc_pv_bufs() SF Markus Elfring
2017-02-19 17:06 ` Majd Dibbiny
2017-02-18 20:49 ` [PATCH 02/29] IB/mlx4: Improve another size determination " SF Markus Elfring
2017-02-19 17:06 ` Majd Dibbiny
2017-02-18 20:50 ` [PATCH 03/29] IB/mlx4: Improve another size determination in mlx4_ib_alloc_demux_ctx() SF Markus Elfring
2017-02-19 17:06 ` Majd Dibbiny
2017-02-18 20:51 ` [PATCH 04/29] IB/mlx4: Improve another size determination in alloc_pv_object() SF Markus Elfring
2017-02-19 17:06 ` Majd Dibbiny
2017-02-18 20:52 ` [PATCH 05/29] IB/mlx4: Fix a typo in a comment line SF Markus Elfring
2017-02-19 17:06 ` Majd Dibbiny
2017-02-18 20:54 ` [PATCH 06/29] IB/mlx4: Delete three unnecessary return statements SF Markus Elfring
2017-02-19 17:06 ` Majd Dibbiny
2017-02-18 20:55 ` [PATCH 07/29] IB/mlx4: Split a condition check in handle_slaves_guid_change() SF Markus Elfring
2017-02-19 17:09 ` Majd Dibbiny
2017-02-18 20:56 ` [PATCH 08/29] IB/mlx4: Delete an unnecessary check before the function call "kfree" in free_pv_object() SF Markus Elfring
2017-02-19 17:11 ` Majd Dibbiny
2017-02-18 20:57 ` [PATCH 09/29] IB/mlx4: Move an assignment out of a check in forward_trap() SF Markus Elfring
2017-02-19 17:12 ` Majd Dibbiny
2017-02-18 20:58 ` [PATCH 10/29] IB/mlx4: Enclose 15 expressions for the sizeof operator by parentheses SF Markus Elfring
2017-02-19 17:21 ` Majd Dibbiny
2017-02-18 20:59 ` [PATCH 11/29] IB/mlx4: Use kmalloc_array() in three functions SF Markus Elfring
2017-02-19 17:21 ` Majd Dibbiny
2017-02-18 21:00 ` [PATCH 12/29] IB/mlx4: Enclose 17 expressions for the sizeof operator by parentheses SF Markus Elfring
2017-02-19 17:21 ` Majd Dibbiny [this message]
2017-02-18 21:01 ` [PATCH 13/29] IB/mlx4: Split a condition check in five functions SF Markus Elfring
2017-02-19 17:21 ` Majd Dibbiny
2017-02-18 21:02 ` [PATCH 14/29] IB/mlx4: Delete an unnecessary variable in __mlx4_ib_query_gid() SF Markus Elfring
2017-02-18 21:03 ` [PATCH 15/29] IB/mlx4: Delete an unnecessary return statement in do_slave_init() SF Markus Elfring
2017-02-19 17:36 ` Majd Dibbiny
2017-02-18 21:04 ` [PATCH 16/29] IB/mlx4: Improve another size determination " SF Markus Elfring
2017-02-18 21:05 ` [PATCH 17/29] IB/mlx4: Improve another size determination in mlx4_ib_add() SF Markus Elfring
2017-02-19 17:36 ` Majd Dibbiny
2017-02-19 17:36 ` Majd Dibbiny
2017-02-18 21:06 ` [PATCH 18/29] IB/mlx4: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-02-18 21:08 ` [PATCH 19/29] IB/mlx4: Delete an unnecessary variable assignment " SF Markus Elfring
2017-02-19 19:42 ` Majd Dibbiny
2017-02-18 21:10 ` [PATCH 20/29] IB/mlx4: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-02-19 19:48 ` Majd Dibbiny
2017-02-18 21:11 ` [PATCH 21/29] IB/mlx4: Delete unnecessary braces " SF Markus Elfring
2017-02-19 19:51 ` Majd Dibbiny
2017-02-18 21:12 ` [PATCH 22/29] IB/mlx4: Use kmalloc_array() in alloc_proxy_bufs() SF Markus Elfring
2017-02-19 19:53 ` Majd Dibbiny
2017-02-18 21:13 ` [PATCH 23/29] IB/mlx4: Improve size determinations in create_qp_common() SF Markus Elfring
2017-02-19 19:54 ` Majd Dibbiny
2017-02-18 21:14 ` [PATCH 24/29] IB/mlx4: Delete unwanted spaces behind usages of the sizeof operator SF Markus Elfring
2017-02-18 21:15 ` [PATCH 25/29] IB/mlx4: Add spaces for better code readability SF Markus Elfring
2017-02-18 21:16 ` [PATCH 26/29] IB/mlx4: Enclose 14 expressions for the sizeof operator by parentheses SF Markus Elfring
2017-02-18 21:17 ` [PATCH 27/29] IB/mlx5: Use kmalloc_array() in create_kernel_qp() SF Markus Elfring
2017-02-18 21:18 ` [PATCH 28/29] IB/mlx5: Less function calls in create_kernel_qp() after error detection SF Markus Elfring
2017-02-18 21:19 ` [PATCH 29/29] IB/mlx5: Use kmalloc_array() in create_srq_kernel() SF Markus Elfring
2017-04-20 20:37 ` [PATCH 00/29] IB/mlx: Fine-tuning for several function implementations Doug Ledford
2017-04-20 21:02 ` SF Markus Elfring
2017-04-21 2:23 ` Doug Ledford
2017-04-21 18:17 ` [PATCH v2 00/17] " SF Markus Elfring
2017-04-21 18:21 ` [PATCH v2 01/17] IB/mlx4: Use kcalloc() in mlx4_ib_alloc_pv_bufs() SF Markus Elfring
2017-04-21 18:24 ` [PATCH v2 02/17] IB/mlx: Use kmalloc_array() in six functions SF Markus Elfring
2017-04-21 18:28 ` [PATCH v2 03/17] IB/mlx4: Improve size determinations " SF Markus Elfring
2017-04-21 18:29 ` [PATCH v2 00/17] IB/mlx: Fine-tuning for several function implementations Bart Van Assche
2017-04-21 19:21 ` SF Markus Elfring
2017-04-21 19:55 ` Bart Van Assche
2017-04-21 18:30 ` [PATCH v2 04/17] IB/mlx4: Fix a typo in a comment line SF Markus Elfring
2017-04-21 18:33 ` [PATCH v2 05/17] IB/mlx4: Delete four unnecessary return statements SF Markus Elfring
2017-04-21 18:36 ` [PATCH v2 06/17] IB/mlx4: Delete an unnecessary check before kfree() in free_pv_object() SF Markus Elfring
2017-04-21 18:37 ` [PATCH v2 07/17] IB/mlx4: Move an assignment out of a check in forward_trap() SF Markus Elfring
2017-04-21 18:38 ` [PATCH v2 08/17] IB/mlx4: Enclose 46 expressions for sizeof by parentheses SF Markus Elfring
2017-04-21 18:40 ` [PATCH v2 09/17] IB/mlx4: Split a condition check in six functions SF Markus Elfring
2017-04-21 18:42 ` [PATCH v2 10/17] IB/mlx4: Delete an unnecessary variable in __mlx4_ib_query_gid() SF Markus Elfring
2017-04-21 18:44 ` [PATCH v2 11/17] IB/mlx4: Delete an unnecessary variable initialisation in mlx4_ib_add() SF Markus Elfring
2017-04-21 18:45 ` [PATCH v2 12/17] IB/mlx4: Delete an unnecessary variable assignment " SF Markus Elfring
2017-04-21 18:46 ` [PATCH v2 13/17] IB/mlx4: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-04-21 18:48 ` [PATCH v2 14/17] IB/mlx4: Delete unnecessary braces " SF Markus Elfring
2017-04-21 18:50 ` [PATCH v2 15/17] IB/mlx4: Delete unwanted spaces behind usages of the sizeof operator SF Markus Elfring
2017-04-21 18:54 ` [PATCH v2 16/17] IB/mlx4: Add spaces for better code readability SF Markus Elfring
2017-04-21 19:28 ` Joe Perches
2017-04-21 18:55 ` [PATCH v2 17/17] IB/mlx5: Less function calls in create_kernel_qp() after error detection SF Markus Elfring
2017-08-06 14:00 ` [PATCH v2 00/17] IB/mlx: Fine-tuning for several function implementations SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15CAFA80-3F81-4FF3-90A6-F215FF69FD33@mellanox.com \
--to=majd@mellanox.com \
--cc=dledford@redhat.com \
--cc=elfring@users.sourceforge.net \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).