From: Min Guo <min.guo@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bin Liu <b-liu@ti.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
<chunfeng.yun@mediatek.com>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] usb: musb: remove unused variable 'devctl'
Date: Fri, 20 Nov 2020 14:48:50 +0800 [thread overview]
Message-ID: <1605854930.3995.8.camel@mhfsdcap03> (raw)
In-Reply-To: <X7UKJtWtE0UZgqAQ@kroah.com>
Hi greg k-h:
On Wed, 2020-11-18 at 12:48 +0100, Greg Kroah-Hartman wrote:
> On Tue, Nov 17, 2020 at 04:21:25PM +0800, min.guo@mediatek.com wrote:
> > From: Min Guo <min.guo@mediatek.com>
> >
> > Remove unused 'devctl' variable to fix compile warnings:
> >
> > drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq':
> > drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set
> > but not used [-Wunused-but-set-variable]
> >
> > Signed-off-by: Min Guo <min.guo@mediatek.com>
> > ---
> > drivers/usb/musb/musbhsdma.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
> > index 0aacfc8be5a1..7acd1635850d 100644
> > --- a/drivers/usb/musb/musbhsdma.c
> > +++ b/drivers/usb/musb/musbhsdma.c
> > @@ -321,8 +321,6 @@ irqreturn_t dma_controller_irq(int irq, void *private_data)
> > musb_channel->channel.status =
> > MUSB_DMA_STATUS_BUS_ABORT;
> > } else {
> > - u8 devctl;
> > -
> > addr = musb_read_hsdma_addr(mbase,
> > bchannel);
> > channel->actual_len = addr
> > @@ -336,8 +334,6 @@ irqreturn_t dma_controller_irq(int irq, void *private_data)
> > < musb_channel->len) ?
> > "=> reconfig 0" : "=> complete");
> >
> > - devctl = musb_readb(mbase, MUSB_DEVCTL);
>
> Are you sure that the hardware does not require this read to complete
> the command? Lots of hardware is that way, so be very careful about
> this. Did you test it?
I have tested this patch on Mediatek's platform, and not sure if it
will affect other vendors' platforms.
Dear Bin:
Does this patch will affect other vendors' platforms?
Best Regards,
Min
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2020-11-20 6:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 8:21 [PATCH] usb: musb: remove unused variable 'devctl' min.guo
2020-11-18 11:48 ` Greg Kroah-Hartman
2020-11-20 6:48 ` Min Guo [this message]
2020-11-20 6:54 ` Greg Kroah-Hartman
2020-11-20 7:42 ` Min Guo
2020-11-20 8:36 ` Greg Kroah-Hartman
2020-11-20 9:02 ` Min Guo
2020-11-20 9:20 ` Greg Kroah-Hartman
2020-11-20 16:15 ` Alan Stern
2020-11-20 16:32 ` Greg Kroah-Hartman
2020-11-20 16:37 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605854930.3995.8.camel@mhfsdcap03 \
--to=min.guo@mediatek.com \
--cc=b-liu@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).