From: Stephen Boyd <sboyd@kernel.org>
To: Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Taniya Das <tdas@codeaurora.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] dt-bindings: clock: Add SM8350 GCC clock bindings
Date: Thu, 10 Dec 2020 12:31:08 -0800 [thread overview]
Message-ID: <160763226856.1580929.7399412663078488395@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20201210061159.GM8403@vkoul-mobl>
Quoting Vinod Koul (2020-12-09 22:11:59)
> On 09-12-20, 22:01, Rob Herring wrote:
> > On Tue, Dec 08, 2020 at 12:17:00PM +0530, Vinod Koul wrote:
>
> > > +required:
> > > + - compatible
> > > + - clocks
> > > + - clock-names
> > > + - reg
> > > + - '#clock-cells'
> > > + - '#reset-cells'
> >
> > You may or may not have power domains?
>
> I have not added them in the driver yet, so I dont think it made sense
> to add them when they are not present. For basic stuff it is not
> required but eventually yes, so I plan to update binding and driver at
> that time
>
They should still be required in the binding though if the hardware has
power domains. It's not like the hardware doesn't have power domains
already or can gain that ability after the fact. The driver should deal
with it when it is ready.
next prev parent reply other threads:[~2020-12-10 20:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 6:46 [PATCH v2 0/5] Add clock drivers for SM8350 Vinod Koul
2020-12-08 6:46 ` [PATCH v2 1/5] dt-bindings: clock: Add RPMHCC bindings " Vinod Koul
2020-12-10 3:59 ` Rob Herring
2020-12-10 20:44 ` Stephen Boyd
2020-12-08 6:46 ` [PATCH v2 2/5] clk: qcom: rpmh: add support for SM8350 rpmh clocks Vinod Koul
2020-12-10 20:48 ` Stephen Boyd
2020-12-08 6:47 ` [PATCH v2 3/5] dt-bindings: clock: Add SM8350 GCC clock bindings Vinod Koul
2020-12-10 4:01 ` Rob Herring
2020-12-10 6:11 ` Vinod Koul
2020-12-10 20:31 ` Stephen Boyd [this message]
2020-12-11 4:29 ` Vinod Koul
2020-12-08 6:47 ` [PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL Vinod Koul
2020-12-10 20:36 ` Stephen Boyd
2020-12-11 5:02 ` Vinod Koul
2020-12-11 7:09 ` Stephen Boyd
2020-12-08 6:47 ` [PATCH v2 5/5] clk: qcom: gcc: Add clock driver for SM8350 Vinod Koul
2020-12-10 20:43 ` Stephen Boyd
2020-12-11 5:43 ` Vinod Koul
2020-12-11 7:10 ` Stephen Boyd
2020-12-13 8:30 ` Taniya Das
2020-12-14 4:40 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160763226856.1580929.7399412663078488395@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=tdas@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).