From: "irqchip-bot for Marc Zyngier" <tip-bot2@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Valentin Schneider <valentin.schneider@arm.com>,
Guenter Roeck <linux@roeck-us.net>, Marc Zyngier <maz@kernel.org>,
tglx@linutronix.de
Subject: [irqchip: irq/irqchip-next] irqchip/bcm2836: Fix IPI acknowledgement after conversion to handle_percpu_devid_irq
Date: Fri, 18 Dec 2020 18:40:42 -0000 [thread overview]
Message-ID: <160831684292.22759.15563002516530918910.tip-bot2@tip-bot2> (raw)
In-Reply-To: <c9fb4ab3-a5cb-648c-6de3-c6a871e60870@roeck-us.net>
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: d7f39c40ebb6986e7371510d1c20a4efee4a7f0d
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/d7f39c40ebb6986e7371510d1c20a4efee4a7f0d
Author: Marc Zyngier <maz@kernel.org>
AuthorDate: Fri, 18 Dec 2020 18:03:46
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Fri, 18 Dec 2020 18:34:17
irqchip/bcm2836: Fix IPI acknowledgement after conversion to handle_percpu_devid_irq
It appears that despite its name, the bcm2836_arm_irqchip_ipi_eoi()
callback is an acknowledgement, and not an EOI. This means that
we lose IPIs that are made pending between the handling of the
IPI and the write to LOCAL_MAILBOX0_CLR0. With the right timing,
things fail nicely.
This used to work with handle_percpu_devid_fasteoi_ipi(), which
started by eoi-ing the interrupt. With the standard fasteoi flow,
this doesn't work anymore.
So let's use this callback for what it is, an ack. Your favourite
RPi-2/3 is back up and running.
Fixes: ffdad793d579 ("irqchip/bcm2836: Make IPIs use handle_percpu_devid_irq()")
Cc: Valentin Schneider <valentin.schneider@arm.com>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/c9fb4ab3-a5cb-648c-6de3-c6a871e60870@roeck-us.net
---
drivers/irqchip/irq-bcm2836.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c
index 5f5eb88..25c9a9c 100644
--- a/drivers/irqchip/irq-bcm2836.c
+++ b/drivers/irqchip/irq-bcm2836.c
@@ -167,7 +167,7 @@ static void bcm2836_arm_irqchip_handle_ipi(struct irq_desc *desc)
chained_irq_exit(chip, desc);
}
-static void bcm2836_arm_irqchip_ipi_eoi(struct irq_data *d)
+static void bcm2836_arm_irqchip_ipi_ack(struct irq_data *d)
{
int cpu = smp_processor_id();
@@ -195,7 +195,7 @@ static struct irq_chip bcm2836_arm_irqchip_ipi = {
.name = "IPI",
.irq_mask = bcm2836_arm_irqchip_dummy_op,
.irq_unmask = bcm2836_arm_irqchip_dummy_op,
- .irq_eoi = bcm2836_arm_irqchip_ipi_eoi,
+ .irq_ack = bcm2836_arm_irqchip_ipi_ack,
.ipi_send_mask = bcm2836_arm_irqchip_ipi_send_mask,
};
next prev parent reply other threads:[~2020-12-18 18:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:41 [PATCH 0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi() Valentin Schneider
2020-11-09 9:41 ` [PATCH 1/5] irqchip/gic, gic-v3: Make SGIs use handle_percpu_devid_irq() Valentin Schneider
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-11-09 9:41 ` [PATCH 2/5] irqchip/armada-370-xp: Make IPIs " Valentin Schneider
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-11-09 9:41 ` [PATCH 3/5] irqchip/bcm2836: " Valentin Schneider
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-12-15 0:21 ` [PATCH 3/5] " Guenter Roeck
2020-12-15 10:19 ` Marc Zyngier
2020-12-15 11:14 ` Valentin Schneider
2020-12-15 12:14 ` Marc Zyngier
2020-12-15 15:21 ` Guenter Roeck
2020-12-15 15:26 ` Marc Zyngier
2020-12-15 15:39 ` Guenter Roeck
2020-12-15 15:46 ` Marc Zyngier
2020-12-15 16:23 ` Guenter Roeck
2020-12-18 5:18 ` Guenter Roeck
2020-12-18 18:40 ` Marc Zyngier
2020-12-18 18:47 ` Guenter Roeck
2020-12-18 18:40 ` irqchip-bot for Marc Zyngier [this message]
2020-12-18 20:36 ` [irqchip: irq/irqchip-next] irqchip/bcm2836: Fix IPI acknowledgement after conversion to handle_percpu_devid_irq Valentin Schneider
2020-12-18 20:53 ` Marc Zyngier
2020-11-09 9:41 ` [PATCH 4/5] irqchip/hip04: Make IPIs use handle_percpu_devid_irq() Valentin Schneider
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-11-09 9:41 ` [PATCH 5/5] Revert "genirq: Add fasteoi IPI flow" Valentin Schneider
2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-12-11 15:01 ` [PATCH 0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi() Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160831684292.22759.15563002516530918910.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).