From: Stephen Boyd <sboyd@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: DTML <devicetree@vger.kernel.org>,
linux-clk@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description
Date: Sun, 20 Dec 2020 10:44:09 -0800 [thread overview]
Message-ID: <160848984935.1580929.936824086681978646@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAFr9PX=f=HyHBk4s3e_vnMDC53R1X18m7sKFCLMMjitPm+8oEQ@mail.gmail.com>
Quoting Daniel Palmer (2020-12-19 22:35:41)
> Hi Stephen,
>
> On Sun, 20 Dec 2020 at 12:39, Stephen Boyd <sboyd@kernel.org> wrote:
> > > + clock-output-names:
> > > + minItems: 8
> > > + maxItems: 8
> > > + description: |
> > > + This should provide a name for the internal PLL clock and then
> > > + a name for each of the divided outputs.
> >
> > Is this necessary?
>
> I found without the names specified in the dt probing of muxes that
> depend on the outputs but appear earlier didn't work.
> Also this same PLL layout seems to be used in some other places so
> eventually I was thinking this driver would get used for those PLLs
> with different output names.
Still seems like it could be auto-generated based on dev_name() +
number. Now that we have a way to specify clk parents via the clocks
property in DT (without any clock-names required) we should be able to
avoid needing clock-output-names in general.
next prev parent reply other threads:[~2020-12-20 18:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 13:50 [PATCH 0/6] ARM: mstar: Basic MPLL support Daniel Palmer
2020-11-14 13:50 ` [PATCH 1/6] dt-bindings: clk: mstar msc313 mpll binding header Daniel Palmer
2020-12-07 19:02 ` Rob Herring
2020-11-14 13:50 ` [PATCH 2/6] dt-bindings: clk: mstar msc313 mpll binding description Daniel Palmer
2020-12-07 19:03 ` Rob Herring
2020-12-20 3:39 ` Stephen Boyd
2020-12-20 6:35 ` Daniel Palmer
2020-12-20 18:44 ` Stephen Boyd [this message]
2020-12-21 8:51 ` Daniel Palmer
2021-02-10 2:29 ` Stephen Boyd
2021-02-11 2:28 ` Daniel Palmer
2021-02-11 2:55 ` Stephen Boyd
2020-11-14 13:50 ` [PATCH 3/6] clk: mstar: MStar/SigmaStar MPLL driver Daniel Palmer
2020-12-20 4:36 ` Stephen Boyd
2020-12-20 6:42 ` Daniel Palmer
2020-12-20 18:43 ` Stephen Boyd
2020-12-21 8:40 ` Daniel Palmer
2020-11-14 13:50 ` [PATCH 4/6] ARM: mstar: Select MSTAR_MSC313_MPLL Daniel Palmer
2020-11-14 13:50 ` [PATCH 5/6] ARM: mstar: Add the external clocks to the base dsti Daniel Palmer
2020-11-14 13:50 ` [PATCH 6/6] ARM: mstar: Add mpll to base dtsi Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160848984935.1580929.936824086681978646@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).