From: David Howells <dhowells@redhat.com>
To: linux-afs@lists.infradead.org
Cc: Gaja Sophie Peters <gaja.peters@math.uni-hamburg.de>,
dhowells@redhat.com,
Gaja Sophie Peters <gaja.peters@math.uni-hamburg.de>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] AFS metadata xattr fixes
Date: Thu, 11 Mar 2021 23:06:24 +0000 [thread overview]
Message-ID: <161550398415.1983424.4857046033308089813.stgit@warthog.procyon.org.uk> (raw)
Here's a pair of fixes for AFS.
(1) Fix an oops in AFS that can be triggered by accessing one of the
afs.yfs.* xattrs against a yfs server[1][2] - for instance by "cp -a"
or "rsync -X". These try and copy all of the xattrs.
They should pay attention to the list in /etc/xattr.conf, but cp
doesn't on Ubuntu and rsync doesn't seem to on Ubuntu or Fedora.
xattr.conf has been modified upstream[3], but a new version hasn't
been cut yet. I've logged a bug against rsync for the problem
there[4].
(2) Stop listing "afs.*" xattrs[6], particularly ACL ones[8]. This
removes them from the list returned by listxattr(), but they're still
available to get/set.
The patches can be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes
Changes:
ver #2:
- Hide all of the afs.* xattrs, not just the ACL ones[7].
David
Link: http://lists.infradead.org/pipermail/linux-afs/2021-March/003498.html [1]
Link: http://lists.infradead.org/pipermail/linux-afs/2021-March/003501.html [2]
Link: https://git.savannah.nongnu.org/cgit/attr.git/commit/?id=74da517cc655a82ded715dea7245ce88ebc91b98 [3]
Link: https://github.com/WayneD/rsync/issues/163 [4]
Link: http://lists.infradead.org/pipermail/linux-afs/2021-March/003516.html [5]
Link: http://lists.infradead.org/pipermail/linux-afs/2021-March/003524.html [6]
Link: http://lists.infradead.org/pipermail/linux-afs/2021-March/003565.html # v1
Link: http://lists.infradead.org/pipermail/linux-afs/2021-March/003568.html [7]
Link: http://lists.infradead.org/pipermail/linux-afs/2021-March/003570.html [8]
---
David Howells (2):
afs: Fix accessing YFS xattrs on a non-YFS server
afs: Stop listxattr() from listing "afs.*" attributes
fs/afs/dir.c | 1 -
fs/afs/file.c | 1 -
fs/afs/inode.c | 1 -
fs/afs/internal.h | 1 -
fs/afs/mntpt.c | 1 -
fs/afs/xattr.c | 23 -----------------------
6 files changed, 28 deletions(-)
next reply other threads:[~2021-03-11 23:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 23:06 David Howells [this message]
2021-03-11 23:06 ` [PATCH v2 1/2] afs: Fix accessing YFS xattrs on a non-YFS server David Howells
2021-03-11 23:06 ` [PATCH v2 2/2] afs: Stop listxattr() from listing "afs.*" attributes David Howells
2021-03-12 20:52 ` Gaja Sophie Peters
2021-03-15 17:02 ` Marc Dionne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161550398415.1983424.4857046033308089813.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=gaja.peters@math.uni-hamburg.de \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).