From: Stephen Boyd <swboyd@chromium.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Sam Ravnborg <sam@ravnborg.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Douglas Anderson <dianders@chromium.org>,
Sean Paul <seanpaul@chromium.org>
Subject: Re: [PATCH v3 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC
Date: Mon, 22 Mar 2021 20:17:55 -0700 [thread overview]
Message-ID: <161646947526.2972785.6883720652669260316@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <YFKc23MwUQAosCs8@pendragon.ideasonboard.com>
Quoting Laurent Pinchart (2021-03-17 17:20:43)
> Hi Stephen,
>
> Reviving a bit of an old thread, for a question.
>
> On Mon, Nov 02, 2020 at 10:11:43AM -0800, Stephen Boyd wrote:
> > @@ -265,6 +267,23 @@ connector_to_ti_sn_bridge(struct drm_connector *connector)
> > static int ti_sn_bridge_connector_get_modes(struct drm_connector *connector)
> > {
> > struct ti_sn_bridge *pdata = connector_to_ti_sn_bridge(connector);
> > + struct edid *edid = pdata->edid;
> > + int num, ret;
> > +
> > + if (!edid) {
> > + pm_runtime_get_sync(pdata->dev);
> > + edid = pdata->edid = drm_get_edid(connector, &pdata->aux.ddc);
> > + pm_runtime_put(pdata->dev);
>
> Is there any specific reason to use the indirect access method, compared
> to the direct method that translates access to an I2C ancillary address
> to an I2C-over-AUX transaction (see page 20 of SLLSEH2B) ? The direct
> method seems it would be more efficient.
>
No I don't think it matters. I was just using the existing support code
that Sean wrote instead of digging into the details. Maybe Sean ran into
something earlier and abandoned that approach?
next prev parent reply other threads:[~2021-03-23 3:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 18:11 [PATCH v3 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading Stephen Boyd
2020-11-02 18:11 ` [PATCH v3 1/4] drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer() Stephen Boyd
2020-11-02 18:11 ` [PATCH v3 2/4] drm/bridge: ti-sn65dsi86: Make polling a busy loop Stephen Boyd
2020-11-02 18:11 ` [PATCH v3 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC Stephen Boyd
2021-03-18 0:20 ` Laurent Pinchart
2021-03-23 3:17 ` Stephen Boyd [this message]
2021-03-23 19:07 ` Doug Anderson
2021-03-23 19:52 ` Laurent Pinchart
2021-05-07 21:32 ` Doug Anderson
2020-11-02 18:11 ` [PATCH v3 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures Stephen Boyd
2020-11-07 11:09 ` [PATCH v3 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161646947526.2972785.6883720652669260316@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=a.hajda@samsung.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).