From: Nicholas Piggin <npiggin@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>,
Xiongwei Song <sxwjean@gmail.com>
Cc: aik@ozlabs.ru, akpm@linux-foundation.org, alistair@popple.id.au,
aneesh.kumar@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
benh@kernel.crashing.org, christophe.leroy@csgroup.eu,
haren@linux.ibm.com, jniethe5@gmail.com,
john.ogness@linutronix.de, kan.liang@linux.intel.com,
kjain@linux.ibm.com, kvm-ppc@vger.kernel.org,
leobras.c@gmail.com, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com,
mikey@neuling.org, Michael Ellerman <mpe@ellerman.id.au>,
msuchanek@suse.de, oleg@redhat.com, paulus@samba.org,
peterx@redhat.com, peterz@infradead.org, pmladek@suse.com,
ravi.bangoria@linux.ibm.com, rppt@kernel.org,
Xiongwei Song <sxwjean@me.com>
Subject: Re: [PATCH v2] powerpc/traps: Enhance readability for trap types
Date: Fri, 02 Apr 2021 10:36:45 +1000 [thread overview]
Message-ID: <1617322416.z3cicnpfxy.astroid@bobo.none> (raw)
In-Reply-To: <20210401161131.GE13863@gate.crashing.org>
Excerpts from Segher Boessenkool's message of April 2, 2021 2:11 am:
> On Thu, Apr 01, 2021 at 10:55:58AM +0800, Xiongwei Song wrote:
>> Segher Boessenkool <segher@kernel.crashing.org> 于2021年4月1日周四 上午6:15写道:
>>
>> > On Wed, Mar 31, 2021 at 08:58:17PM +1100, Michael Ellerman wrote:
>> > > So perhaps:
>> > >
>> > > EXC_SYSTEM_RESET
>> > > EXC_MACHINE_CHECK
>> > > EXC_DATA_STORAGE
>> > > EXC_DATA_SEGMENT
>> > > EXC_INST_STORAGE
>> > > EXC_INST_SEGMENT
>> > > EXC_EXTERNAL_INTERRUPT
>> > > EXC_ALIGNMENT
>> > > EXC_PROGRAM_CHECK
>> > > EXC_FP_UNAVAILABLE
>> > > EXC_DECREMENTER
>> > > EXC_HV_DECREMENTER
>> > > EXC_SYSTEM_CALL
>> > > EXC_HV_DATA_STORAGE
>> > > EXC_PERF_MONITOR
>> >
>> > These are interrupt (vectors), not exceptions. It doesn't matter all
>> > that much, but confusing things more isn't useful either! There can be
>> > multiple exceptions that all can trigger the same interrupt.
>> >
>> > When looking at the reference manual of e500 and e600 from NXP
>> official, they call them as interrupts.While looking at the "The
>> Programming Environments"
>> that is also from NXP, they call them exceptions. Looks like there is
>> no explicit distinction between interrupts and exceptions.
>
> The architecture documents have always called it interrupts. The PEM
> says it calls them exceptions instead, but they are called interrupts in
> the architecture (and the PEM says that, too).
>
>> Here is the "The Programming Environments" link:
>> https://www.nxp.com.cn/docs/en/user-guide/MPCFPE_AD_R1.pdf
>
> That document is 24 years old. The architecture is still published,
> new versions regularly.
>
>> As far as I know, the values of interrupts or exceptions above are defined
>> explicitly in reference manual or the programming environments.
>
> They are defined in the architecture.
>
>> Could
>> you please provide more details about multiple exceptions with the same
>> interrupts?
>
> The simplest example is 700, program interrupt. There are many causes
> for it, including all the exceptions in FPSCR: VX, ZX, OX, UX, XX, and
> VX is actually divided into nine separate cases itself. There also are
> the various causes of privileged instruction type program interrupts,
> and the trap type program interrupt, but the FEX ones are most obvious
> here.
Also:
* Some interrupts have no corresponding exception (system call and
system call vectored). This is not just semantics or a bug in the ISA
because it is different from other synchronous interrupts: instructions
which cause exceptions (e.g., a page fault) do not complete before
taking the interrupt whereas sc does.
* It's quite usual for an exception to not cause an interrupt
immediately (MSR[EE]=0, HMEER) or never cause one and be cleared by
other means (msgclr, mtDEC, mtHMER, etc).
* It's possible for an exception to cause different interrupts!
A decrementer exception usually causes a decrementer interrupt, but it
can cause a system reset interrupt if the processor was in a power
saving mode. A data storage exception can cause a DSI or HDSI interrupt
depending on LPCR settings, and many other examples.
So I agree with Segher on this. We should use interrupt for interrupts,
reduce exception except where we really mean it, and move away from vec
and trap (I've got this wrong in the past too I admit). We don't have to
do it all immediately, but new code should go in this direction.
Thanks,
Nick
next prev parent reply other threads:[~2021-04-02 0:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 15:04 [PATCH v2] powerpc/traps: Enhance readability for trap types Xiongwei Song
2021-03-31 9:58 ` Michael Ellerman
2021-03-31 21:25 ` Segher Boessenkool
2021-04-01 2:39 ` Michael Ellerman
2021-04-01 8:01 ` Nicholas Piggin
2021-04-01 16:16 ` Segher Boessenkool
2021-04-05 12:10 ` Xiongwei Song
[not found] ` <CAEVVKH8XDiEGHjXj6sJAHynhwqKWpNqj_Ws03AqwNjR8OmHf5w@mail.gmail.com>
2021-04-01 16:11 ` Segher Boessenkool
2021-04-02 0:36 ` Nicholas Piggin [this message]
2021-04-05 12:18 ` Xiongwei Song
2021-04-05 12:03 ` Xiongwei Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617322416.z3cicnpfxy.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=aik@ozlabs.ru \
--cc=akpm@linux-foundation.org \
--cc=alistair@popple.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=haren@linux.ibm.com \
--cc=jniethe5@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=leobras.c@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rppt@kernel.org \
--cc=segher@kernel.crashing.org \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).