From: "tip-bot2 for Peter Zijlstra" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <frederic@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/nohz] tick/nohz: Call tick_nohz_task_switch() with interrupts disabled
Date: Thu, 13 May 2021 13:17:26 -0000 [thread overview]
Message-ID: <162091184636.29796.12181915470545082709.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20210512232924.150322-10-frederic@kernel.org>
The following commit has been merged into the timers/nohz branch of tip:
Commit-ID: 0fdcccfafcffac70b452b3127cc3d981f0117655
Gitweb: https://git.kernel.org/tip/0fdcccfafcffac70b452b3127cc3d981f0117655
Author: Peter Zijlstra <peterz@infradead.org>
AuthorDate: Thu, 13 May 2021 01:29:23 +02:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 13 May 2021 14:21:23 +02:00
tick/nohz: Call tick_nohz_task_switch() with interrupts disabled
Call tick_nohz_task_switch() slightly earlier after the context switch
to benefit from disabled IRQs. This way the function doesn't need to
disable them once more.
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210512232924.150322-10-frederic@kernel.org
---
kernel/sched/core.c | 2 +-
kernel/time/tick-sched.c | 7 +------
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 78e480f..8f86ac2 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4212,6 +4212,7 @@ static struct rq *finish_task_switch(struct task_struct *prev)
vtime_task_switch(prev);
perf_event_task_sched_in(prev, current);
finish_task(prev);
+ tick_nohz_task_switch();
finish_lock_switch(rq);
finish_arch_post_lock_switch();
kcov_finish_switch(current);
@@ -4257,7 +4258,6 @@ static struct rq *finish_task_switch(struct task_struct *prev)
put_task_struct_rcu_user(prev);
}
- tick_nohz_task_switch();
return rq;
}
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 197a3bd..6ea619d 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -487,13 +487,10 @@ void tick_nohz_dep_clear_signal(struct signal_struct *sig, enum tick_dep_bits bi
*/
void __tick_nohz_task_switch(void)
{
- unsigned long flags;
struct tick_sched *ts;
- local_irq_save(flags);
-
if (!tick_nohz_full_cpu(smp_processor_id()))
- goto out;
+ return;
ts = this_cpu_ptr(&tick_cpu_sched);
@@ -502,8 +499,6 @@ void __tick_nohz_task_switch(void)
atomic_read(¤t->signal->tick_dep_mask))
tick_nohz_full_kick();
}
-out:
- local_irq_restore(flags);
}
/* Get the boot-time nohz CPU list from the kernel parameters. */
next prev parent reply other threads:[~2021-05-13 13:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 23:29 [GIT PULL] tick/nohz updates v3 Frederic Weisbecker
2021-05-12 23:29 ` [PATCH 01/10] tick/nohz: Evaluate the CPU expression after the static key Frederic Weisbecker
2021-05-13 13:17 ` [tip: timers/nohz] " tip-bot2 for Peter Zijlstra
2021-05-12 23:29 ` [PATCH 02/10] tick/nohz: Conditionally restart tick on idle exit Frederic Weisbecker
2021-05-13 13:17 ` [tip: timers/nohz] " tip-bot2 for Yunfeng Ye
2021-05-12 23:29 ` [PATCH 03/10] tick/nohz: Remove superflous check for CONFIG_VIRT_CPU_ACCOUNTING_NATIVE Frederic Weisbecker
2021-05-13 13:17 ` [tip: timers/nohz] " tip-bot2 for Frederic Weisbecker
2021-05-12 23:29 ` [PATCH 04/10] tick/nohz: Update idle_exittime on actual idle exit Frederic Weisbecker
2021-05-13 13:17 ` [tip: timers/nohz] " tip-bot2 for Yunfeng Ye
2021-05-12 23:29 ` [PATCH 05/10] tick/nohz: Update nohz_full Kconfig help Frederic Weisbecker
2021-05-13 13:17 ` [tip: timers/nohz] " tip-bot2 for Frederic Weisbecker
2021-05-12 23:29 ` [PATCH 06/10] tick/nohz: Only wakeup a single target cpu when kicking a task Frederic Weisbecker
2021-05-13 13:17 ` [tip: timers/nohz] tick/nohz: Only wake up " tip-bot2 for Frederic Weisbecker
2021-05-12 23:29 ` [PATCH 07/10] tick/nohz: Change signal tick dependency to wakeup CPUs of member tasks Frederic Weisbecker
2021-05-13 13:17 ` [tip: timers/nohz] tick/nohz: Change signal tick dependency to wake up " tip-bot2 for Marcelo Tosatti
2021-05-12 23:29 ` [PATCH 08/10] tick/nohz: Kick only _queued_ task whose tick dependency is updated Frederic Weisbecker
2021-05-13 13:17 ` [tip: timers/nohz] " tip-bot2 for Marcelo Tosatti
2021-05-12 23:29 ` [PATCH 09/10] tick/nohz: Call tick_nohz_task_switch() with interrupts disabled Frederic Weisbecker
2021-05-13 13:17 ` tip-bot2 for Peter Zijlstra [this message]
2021-05-12 23:29 ` [PATCH 10/10] MAINTAINERS: Add myself as context tracking maintainer Frederic Weisbecker
2021-05-19 9:21 ` [tip: timers/nohz] " tip-bot2 for Frederic Weisbecker
2021-05-13 12:23 ` [GIT PULL] tick/nohz updates v3 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162091184636.29796.12181915470545082709.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).