From: Stanley Chu <stanley.chu@mediatek.com>
To: Can Guo <cang@codeaurora.org>
Cc: <asutoshd@codeaurora.org>, <nguyenb@codeaurora.org>,
<hongwus@codeaurora.org>, <linux-scsi@vger.kernel.org>,
<kernel-team@android.com>, Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bean Huo <beanhuo@micron.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/3] scsi: ufs: Remove a redundant command completion logic in error handler
Date: Tue, 25 May 2021 12:15:53 +0800 [thread overview]
Message-ID: <1621916153.7096.0.camel@mtkswgap22> (raw)
In-Reply-To: <1621845419-14194-2-git-send-email-cang@codeaurora.org>
On Mon, 2021-05-24 at 01:36 -0700, Can Guo wrote:
> ufshcd_host_reset_and_restore() anyways completes all pending requests
> before starts re-probing, so there is no need to complete the command on
> the highest bit in tr_doorbell in advance.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> ---
> drivers/scsi/ufs/ufshcd.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index d543864..c4b37d2 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6123,19 +6123,6 @@ static void ufshcd_err_handler(struct work_struct *work)
> do_reset:
> /* Fatal errors need reset */
> if (needs_reset) {
> - unsigned long max_doorbells = (1UL << hba->nutrs) - 1;
> -
> - /*
> - * ufshcd_reset_and_restore() does the link reinitialization
> - * which will need atleast one empty doorbell slot to send the
> - * device management commands (NOP and query commands).
> - * If there is no slot empty at this moment then free up last
> - * slot forcefully.
> - */
> - if (hba->outstanding_reqs == max_doorbells)
> - __ufshcd_transfer_req_compl(hba,
> - (1UL << (hba->nutrs - 1)));
> -
> hba->force_reset = false;
> spin_unlock_irqrestore(hba->host->host_lock, flags);
> err = ufshcd_reset_and_restore(hba);
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
next prev parent reply other threads:[~2021-05-25 4:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1621845419-14194-1-git-send-email-cang@codeaurora.org>
2021-05-24 8:36 ` [PATCH v1 1/3] scsi: ufs: Remove a redundant command completion logic in error handler Can Guo
2021-05-24 16:43 ` Bart Van Assche
2021-05-25 4:15 ` Stanley Chu [this message]
2021-05-31 7:14 ` Bean Huo
2021-05-24 8:36 ` [PATCH v1 2/3] scsi: ufs: Optimize host lock on transfer requests send/compl paths Can Guo
2021-05-24 20:10 ` Bart Van Assche
2021-05-25 1:34 ` Asutosh Das (asd)
2021-05-25 8:24 ` Avri Altman
2021-05-28 7:30 ` Avri Altman
2021-06-02 21:18 ` Asutosh Das (asd)
2021-05-25 1:40 ` Can Guo
2021-05-25 16:40 ` Bart Van Assche
2021-05-31 16:04 ` Bean Huo
2021-06-02 2:14 ` Can Guo
2021-06-03 0:18 ` Bart Van Assche
2021-06-03 2:54 ` Stanley Chu
2021-06-04 1:49 ` Can Guo
2021-06-17 2:49 ` Bart Van Assche
2021-06-23 2:04 ` Can Guo
2021-06-28 22:58 ` Bart Van Assche
2021-06-29 5:41 ` Can Guo
2021-07-01 15:57 ` Bart Van Assche
2021-05-24 8:36 ` [PATCH v1 3/3] scsi: ufs: Utilize Transfer Request List Completion Notification Register Can Guo
2021-05-31 16:05 ` Bean Huo
2021-06-03 2:54 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1621916153.7096.0.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).