From: kan.liang@linux.intel.com
To: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org
Cc: eranian@google.com, namhyung@kernel.org, acme@kernel.org,
jolsa@redhat.com, ak@linux.intel.com,
Kan Liang <kan.liang@linux.intel.com>,
stable@vger.kernel.org
Subject: [PATCH 7/7] perf/x86/intel/uncore: Fix invalid unit check
Date: Wed, 23 Jun 2021 18:22:09 -0700 [thread overview]
Message-ID: <1624497729-158864-8-git-send-email-kan.liang@linux.intel.com> (raw)
In-Reply-To: <1624497729-158864-1-git-send-email-kan.liang@linux.intel.com>
From: Kan Liang <kan.liang@linux.intel.com>
The uncore unit with the type ID 0 and the unit ID 0 is missed.
The table3 of the uncore unit maybe 0. The
uncore_discovery_invalid_unit() mistakenly treated it as an invalid
value.
Remove the !unit.table3 check.
Fixes: edae1f06c2cd ("perf/x86/intel/uncore: Parse uncore discovery tables")
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Cc: stable@vger.kernel.org
---
arch/x86/events/intel/uncore_discovery.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/intel/uncore_discovery.h b/arch/x86/events/intel/uncore_discovery.h
index 7280c8a..6d735611 100644
--- a/arch/x86/events/intel/uncore_discovery.h
+++ b/arch/x86/events/intel/uncore_discovery.h
@@ -30,7 +30,7 @@
#define uncore_discovery_invalid_unit(unit) \
- (!unit.table1 || !unit.ctl || !unit.table3 || \
+ (!unit.table1 || !unit.ctl || \
unit.table1 == -1ULL || unit.ctl == -1ULL || \
unit.table3 == -1ULL)
--
2.7.4
prev parent reply other threads:[~2021-06-24 1:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 1:22 [PATCH 0/7] perf: Add Sapphire Rapids server uncore support kan.liang
2021-06-24 1:22 ` [PATCH 1/7] driver core: Add a way to get to bus devices kset kan.liang
2021-06-24 5:41 ` Greg KH
2021-06-24 1:22 ` [PATCH 2/7] perf: Create a symlink for a PMU kan.liang
2021-06-24 5:48 ` Greg KH
2021-06-24 14:24 ` Andi Kleen
2021-06-24 14:29 ` Greg KH
2021-06-24 15:24 ` Andi Kleen
2021-06-24 15:31 ` Greg KH
2021-06-24 17:07 ` Liang, Kan
2021-06-24 17:35 ` Greg KH
2021-06-24 17:49 ` Andi Kleen
2021-06-25 5:18 ` Greg KH
2021-06-25 5:17 ` Greg KH
2021-06-24 17:28 ` Andi Kleen
2021-06-25 5:19 ` Greg KH
2021-06-25 14:22 ` Andi Kleen
2021-06-25 14:38 ` Greg KH
2021-06-25 14:49 ` Andi Kleen
2021-06-25 15:03 ` Liang, Kan
2021-06-25 15:44 ` Andi Kleen
2021-06-25 15:57 ` Liang, Kan
2021-06-25 16:18 ` Liang, Kan
2021-06-27 11:02 ` Greg KH
2021-06-27 16:30 ` Andi Kleen
2021-06-28 6:55 ` Greg KH
2021-06-28 15:00 ` Andi Kleen
2021-06-24 1:22 ` [PATCH 3/7] perf/x86/intel/uncore: Create a symlink for an uncore PMU kan.liang
2021-06-24 5:44 ` Greg KH
2021-06-24 1:22 ` [PATCH 4/7] perf/x86/intel/uncore: Add Sapphire Rapids server support kan.liang
2021-06-24 1:22 ` [PATCH 5/7] perf/x86/intel/uncore: Factor out snr_uncore_mmio_map() kan.liang
2021-06-24 1:22 ` [PATCH 6/7] perf/x86/intel/uncore: Support free-running counters on Sapphire Rapids server kan.liang
2021-06-24 1:22 ` kan.liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1624497729-158864-8-git-send-email-kan.liang@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).