From: Rob Herring <robh@kernel.org>
To: Apurva Nandan <a-nandan@ti.com>
Cc: Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org,
Richard Weinberger <richard@nod.at>,
Miquel Raynal <miquel.raynal@bootlin.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: spi-nand: Convert to DT schema format
Date: Mon, 19 Jul 2021 07:47:28 -0600 [thread overview]
Message-ID: <1626702448.437777.1811203.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210718004125.733-1-a-nandan@ti.com>
On Sun, 18 Jul 2021 00:41:25 +0000, Apurva Nandan wrote:
> Convert spi-nand.txt binding to YAML format with an added example.
>
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
> .../devicetree/bindings/mtd/spi-nand.txt | 5 --
> .../devicetree/bindings/mtd/spi-nand.yaml | 74 +++++++++++++++++++
> 2 files changed, 74 insertions(+), 5 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.txt
> create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.example.dt.yaml: spi-flash@1: $nodename:0: 'spi-flash@1' does not match '^flash(@.*)?$'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/spi-nand.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.example.dt.yaml: spi-flash@1: 'rx-sample-delay-ns' does not match any of the regexes: '^otp(-[0-9]+)?$', '^partition@', 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/spi-nand.yaml
\ndoc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1506558
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-07-19 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 0:41 [PATCH] dt-bindings: mtd: spi-nand: Convert to DT schema format Apurva Nandan
2021-07-19 13:47 ` Rob Herring [this message]
2021-07-20 14:13 ` Nandan, Apurva
2021-07-19 15:24 ` Rob Herring
2021-07-20 14:15 ` Nandan, Apurva
2021-07-21 10:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1626702448.437777.1811203.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a-nandan@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).