From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: bhelgaas@google.com,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
jonathanh@nvidia.com, thierry.reding@gmail.com, robh@kernel.org
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] PCI: tegra: Fix OF node reference leak
Date: Thu, 5 Aug 2021 11:43:14 +0100 [thread overview]
Message-ID: <162816017970.17991.9169417632084960512.b4-ty@arm.com> (raw)
In-Reply-To: <55b11e9a7fa2987fbc0869d68ae59888954d65e2.1620148539.git.christophe.jaillet@wanadoo.fr>
On Tue, 4 May 2021 19:17:42 +0200, Christophe JAILLET wrote:
> Commit 9e38e690ace3 ("PCI: tegra: Fix OF node reference leak") has fixed
> some node reference leaks in this function but missed some of them.
>
> In fact, having 'port' referenced in the 'rp' structure is not enough to
> prevent the leak, until 'rp' is actually added in the 'pcie->ports' list.
>
> Add the missing 'goto err_node_put' accordingly.
Applied to pci/tegra, thanks!
[1/3] PCI: tegra: Fix OF node reference leak
https://git.kernel.org/lpieralisi/pci/c/eff21f5da3
[2/3] PCI: tegra: Use 'seq_puts' instead of 'seq_printf'
https://git.kernel.org/lpieralisi/pci/c/804b2b6f2a
[3/3] PCI: tegra: make const array err_msg static
https://git.kernel.org/lpieralisi/pci/c/fd44e8efcc
Thanks,
Lorenzo
prev parent reply other threads:[~2021-08-05 10:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 17:17 [PATCH 1/3] PCI: tegra: Fix OF node reference leak Christophe JAILLET
2021-05-04 17:17 ` [PATCH 2/3] PCI: tegra: Use 'seq_puts' instead of 'seq_printf' Christophe JAILLET
2021-07-05 17:01 ` Vidya Sagar
2021-05-04 17:18 ` [PATCH 3/3] PCI: tegra: make const array err_msg static Christophe JAILLET
2021-07-05 17:01 ` Vidya Sagar
2021-07-05 22:31 ` Krzysztof Wilczyński
2021-07-07 18:24 ` Christophe JAILLET
2021-07-07 19:52 ` Krzysztof Wilczyński
2021-06-22 10:42 ` [PATCH 1/3] PCI: tegra: Fix OF node reference leak Lorenzo Pieralisi
2021-07-05 17:00 ` Vidya Sagar
2021-08-05 10:43 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162816017970.17991.9169417632084960512.b4-ty@arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).