From: Mark Brown <broonie@kernel.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
lgirdwood@gmail.com, matthias.bgg@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] isoc: mediatek: Check for error clk pointer
Date: Fri, 24 Dec 2021 16:17:36 +0000 [thread overview]
Message-ID: <164036265653.3720027.11806563702893486753.b4-ty@kernel.org> (raw)
In-Reply-To: <20211222015157.1025853-1-jiasheng@iscas.ac.cn>
On Wed, 22 Dec 2021 09:51:57 +0800, Jiasheng Jiang wrote:
> On Wed, Dec 22, 2021 at 01:57:15AM +0800, Mark Brown wrote:
> >> + for (i = CLK_NONE + 1; i < CLK_MAX; i++) {
> >> clk[i] = devm_clk_get(&pdev->dev, clk_names[i]);
> >> + if (IS_ERR(clk[i]))
> >> + return PTR_ERR(clk[i]);
> >
> > This now pays attention to the error code here which is good but...
> >
> >> - init_clks(pdev, clk);
> >> + ret = init_clks(pdev, clk);
> >> + if (ret)
> >> + return ERR_PTR(-ENOMEM);
> >
> > ...then discards it here with a random most likely inappropriate error
> > code.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] isoc: mediatek: Check for error clk pointer
commit: 9de2b9286a6dd16966959b3cb34fc2ddfd39213e
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
next prev parent reply other threads:[~2021-12-24 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 1:51 [PATCH v2] isoc: mediatek: Check for error clk pointer Jiasheng Jiang
2021-12-24 14:06 ` Mark Brown
2021-12-24 16:17 ` Mark Brown [this message]
2022-01-28 9:51 ` BUG: " Frank Wunderlich
2022-02-06 17:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164036265653.3720027.11806563702893486753.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=jiasheng@iscas.ac.cn \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).