From: Yunsheng Lin <linyunsheng@huawei.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <hawk@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v2 2/2] page_pool: optimize the cpu sync operation when DMA mapping
Date: Mon, 23 Aug 2021 11:56:48 +0800 [thread overview]
Message-ID: <16468e57-49d8-0a23-0058-c920af99d74a@huawei.com> (raw)
In-Reply-To: <YR94YYRv2qpQtdSZ@Iliass-MBP>
On 2021/8/20 17:39, Ilias Apalodimas wrote:
> On Fri, Aug 20, 2021 at 02:56:51PM +0800, Yunsheng Lin wrote:
>> If the DMA_ATTR_SKIP_CPU_SYNC is not set, cpu syncing is
>> also done in dma_map_page_attrs(), so set the attrs according
>> to pool->p.flags to avoid calling cpu sync function again.
>
> Isn't DMA_ATTR_SKIP_CPU_SYNC checked within dma_map_page_attrs() anyway?
Yes, the checking in dma_map_page_attrs() should save us from
calling dma_sync_single_for_device() again if we set the attrs
according to "pool->p.flags & PP_FLAG_DMA_SYNC_DEV".
As dma_sync_single_for_device() is EXPORT_SYMBOL()'ed, and
should be a no-op for dma coherent device, so there may be a
function calling overhead for dma coherent device, letting
dma_map_page_attrs() handling the sync seems to avoid the stack
pushing/poping overhead:
https://elixir.bootlin.com/linux/latest/source/kernel/dma/direct.h#L104
The one thing I am not sure about is that the pool->p.offset
and pool->p.max_len are used to decide the sync range before this
patch, while the sync range is the same as the map range when doing
the sync in dma_map_page_attrs().
I assumed the above is not a issue? only sync more than we need?
and it won't hurt the performance?
>
> Regards
> /Ilias
>>
>> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
>> ---
>> net/core/page_pool.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
>> index 1a69784..3df5554 100644
>> --- a/net/core/page_pool.c
>> +++ b/net/core/page_pool.c
>> @@ -191,8 +191,12 @@ static void page_pool_dma_sync_for_device(struct page_pool *pool,
>>
>> static bool page_pool_dma_map(struct page_pool *pool, struct page *page)
>> {
>> + unsigned long attrs = DMA_ATTR_SKIP_CPU_SYNC;
>> dma_addr_t dma;
>>
>> + if (pool->p.flags & PP_FLAG_DMA_SYNC_DEV)
>> + attrs = 0;
>> +
>> /* Setup DMA mapping: use 'struct page' area for storing DMA-addr
>> * since dma_addr_t can be either 32 or 64 bits and does not always fit
>> * into page private data (i.e 32bit cpu with 64bit DMA caps)
>> @@ -200,15 +204,12 @@ static bool page_pool_dma_map(struct page_pool *pool, struct page *page)
>> */
>> dma = dma_map_page_attrs(pool->p.dev, page, 0,
>> (PAGE_SIZE << pool->p.order),
>> - pool->p.dma_dir, DMA_ATTR_SKIP_CPU_SYNC);
>> + pool->p.dma_dir, attrs);
>> if (dma_mapping_error(pool->p.dev, dma))
>> return false;
>>
>> page_pool_set_dma_addr(page, dma);
>>
>> - if (pool->p.flags & PP_FLAG_DMA_SYNC_DEV)
>> - page_pool_dma_sync_for_device(pool, page, pool->p.max_len);
>> -
>> return true;
>> }
>>
>> --
>> 2.7.4
>>
> .
>
next prev parent reply other threads:[~2021-08-23 3:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 6:56 [PATCH net-next v2 0/2] Some minor optimization for page pool Yunsheng Lin
2021-08-20 6:56 ` [PATCH net-next v2 1/2] page_pool: use relaxed atomic for release side accounting Yunsheng Lin
2021-08-20 7:12 ` Jesper Dangaard Brouer
2021-08-20 6:56 ` [PATCH net-next v2 2/2] page_pool: optimize the cpu sync operation when DMA mapping Yunsheng Lin
2021-08-20 9:39 ` Ilias Apalodimas
2021-08-23 3:56 ` Yunsheng Lin [this message]
2021-08-23 12:42 ` Ilias Apalodimas
2021-08-24 7:00 ` Yunsheng Lin
2021-08-24 9:04 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16468e57-49d8-0a23-0058-c920af99d74a@huawei.com \
--to=linyunsheng@huawei.com \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).