From: "tip-bot2 for Mel Gorman" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Mel Gorman <mgorman@techsingularity.net>,
Ingo Molnar <mingo@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/numa: Document vma_numab_state fields
Date: Tue, 10 Oct 2023 09:43:49 -0000 [thread overview]
Message-ID: <169693102968.3135.4439690793475045331.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20231010083143.19593-2-mgorman@techsingularity.net>
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 9ae5c00ea2e600a8b823f9b95606dd244f3096bf
Gitweb: https://git.kernel.org/tip/9ae5c00ea2e600a8b823f9b95606dd244f3096bf
Author: Mel Gorman <mgorman@techsingularity.net>
AuthorDate: Tue, 10 Oct 2023 09:31:38 +01:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 10 Oct 2023 11:10:00 +02:00
sched/numa: Document vma_numab_state fields
Document the intended usage of the fields.
[ mingo: Reformatted to take less vertical space & tidied it up. ]
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20231010083143.19593-2-mgorman@techsingularity.net
---
include/linux/mm_types.h | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 36c5b43..d7f042e 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -551,8 +551,29 @@ struct vma_lock {
};
struct vma_numab_state {
+ /*
+ * Initialised as time in 'jiffies' after which VMA
+ * should be scanned. Delays first scan of new VMA by at
+ * least sysctl_numa_balancing_scan_delay:
+ */
unsigned long next_scan;
+
+ /*
+ * Time in jiffies when access_pids[] is reset to
+ * detect phase change behaviour:
+ */
unsigned long next_pid_reset;
+
+ /*
+ * Approximate tracking of PIDs that trapped a NUMA hinting
+ * fault. May produce false positives due to hash collisions.
+ *
+ * [0] Previous PID tracking
+ * [1] Current PID tracking
+ *
+ * Window moves after next_pid_reset has expired approximately
+ * every VMA_PID_RESET_PERIOD jiffies:
+ */
unsigned long access_pids[2];
};
next prev parent reply other threads:[~2023-10-10 9:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 8:31 [PATCH 0/6] sched/numa: Complete scanning of partial and inactive VMAs Mel Gorman
2023-10-10 8:31 ` [PATCH 1/6] sched/numa: Document vma_numab_state fields Mel Gorman
2023-10-10 9:43 ` tip-bot2 for Mel Gorman [this message]
2023-10-10 8:31 ` [PATCH 2/6] sched/numa: Rename vma_numab_state.access_pids Mel Gorman
2023-10-10 9:43 ` [tip: sched/core] sched/numa: Rename vma_numab_state::access_pids[] => ::pids_active[], ::next_pid_reset => ::pids_active_reset tip-bot2 for Mel Gorman
2023-10-10 8:31 ` [PATCH 3/6] sched/numa: Trace decisions related to skipping VMAs Mel Gorman
2023-10-10 9:43 ` [tip: sched/core] " tip-bot2 for Mel Gorman
2023-10-10 8:31 ` [PATCH 4/6] sched/numa: Move up the access pid reset logic Mel Gorman
2023-10-10 9:43 ` [tip: sched/core] " tip-bot2 for Raghavendra K T
2023-10-10 8:31 ` [PATCH 5/6] sched/numa: Complete scanning of partial VMAs regardless of PID activity Mel Gorman
2023-10-10 9:43 ` [tip: sched/core] " tip-bot2 for Mel Gorman
2023-10-10 21:47 ` tip-bot2 for Mel Gorman
2023-10-10 8:31 ` [PATCH 6/6] sched/numa: Complete scanning of inactive VMAs when there is no alternative Mel Gorman
2023-10-10 9:23 ` Ingo Molnar
2023-10-10 9:57 ` Mel Gorman
2023-10-10 21:39 ` Ingo Molnar
2023-10-10 11:40 ` Raghavendra K T
2024-02-24 4:50 ` Raghavendra K T
2023-10-10 9:43 ` [tip: sched/core] " tip-bot2 for Mel Gorman
2023-10-10 11:42 ` [PATCH 6/6] " Raghavendra K T
2023-10-10 21:47 ` [tip: sched/core] " tip-bot2 for Mel Gorman
2023-10-10 11:39 ` [PATCH 0/6] sched/numa: Complete scanning of partial and inactive VMAs Raghavendra K T
2023-10-10 21:45 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169693102968.3135.4439690793475045331.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).