From: "liwei (CM)" <liwei213@huawei.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"xuwei (O)" <xuwei5@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kevin Hilman <khilman@baylibre.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Riku Voipio <riku.voipio@linaro.org>,
Thierry Reding <treding@nvidia.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
zangleigang <zangleigang@hisilicon.com>,
Gengjianfeng <gengjianfeng@hisilicon.com>,
Guodong Xu <guodong.xu@linaro.org>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
"Fengbaopeng (kevin,
Kirin Solution Dept)" <fengbaopeng@hisilicon.com>
Subject: 答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs
Date: Fri, 23 Feb 2018 08:35:54 +0000 [thread overview]
Message-ID: <1699CE87DE933F49876AD744B5DC140FA56267@DGGEMM506-MBS.china.huawei.com> (raw)
In-Reply-To: <CAK8P3a2b3rLHyM+vMppCkAR3VYbhw-b0LpuWfLCqjs7z9n+hyw@mail.gmail.com>
Hi, Arnd
Sorry late for you.
The following two suggestions we have really discussed
https://lkml.org/lkml/2017/11/30/1077
-----邮件原件-----
发件人: arndbergmann@gmail.com [mailto:arndbergmann@gmail.com] 代表 Arnd Bergmann
发送时间: 2018年2月19日 17:58
收件人: liwei (CM)
抄送: Rob Herring; Mark Rutland; xuwei (O); Catalin Marinas; Will Deacon; Vinayak Holikatti; James E.J. Bottomley; Martin K. Petersen; Kevin Hilman; Gregory CLEMENT; Thomas Petazzoni; Masahiro Yamada; Riku Voipio; Thierry Reding; Krzysztof Kozlowski; Eric Anholt; DTML; Linux Kernel Mailing List; Linux ARM; linux-scsi; zangleigang; Gengjianfeng; Guodong Xu; Zhangfei Gao; Fengbaopeng (kevin, Kirin Solution Dept)
主题: Re: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs
On Tue, Feb 13, 2018 at 11:14 AM, Li Wei <liwei213@huawei.com> wrote:
> add ufs node document for Hisilicon.
>
> Signed-off-by: Li Wei <liwei213@huawei.com>
> ---
> Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 37
> ++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ufs/ufs-hisi.txt
I'm pretty sure we've discussed it before, but can you make this so that the generic properties are part of the ufshcd binding, and you refer to it from here, only describing in what ways the hisi ufs binding differs from the standard?
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> new file mode 100644
> index 000000000000..0d21b57496cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> @@ -0,0 +1,37 @@
> +* Hisilicon Universal Flash Storage (UFS) Host Controller
> +
> +UFS nodes are defined to describe on-chip UFS hardware macro.
> +Each UFS Host Controller should have its own node.
> +
> +Required properties:
> +- compatible : compatible list, contains one of the following -
> + "hisilicon,hi3660-ufs", "jedec,ufs-1.1" for hisi ufs
> + host controller present on Hi36xx chipset.
> +- reg : should contain UFS register address space & UFS SYS CTRL register address,
> +- interrupt-parent : interrupt device
> +- interrupts : interrupt number
> +- clocks : List of phandle and clock specifier pairs
> +- clock-names : List of clock input name strings sorted in the same
> + order as the clocks property.
> +"ref_clk", "phy_clk" is optional
The clock names sound generic enough, should we have both in the generic binding?
"ref_clk" is in the ufshcd-pltfrm binding, but "phy_clk" is not; what do you mean is that these two don't need to document here?
> +- resets : reset node register, one reset the clk and the other reset the controller
> +- reset-names : describe reset node register
This looks incomplete. What is the name of the reset line supposed to be?
I'd also suggest you document it in the ufshcd binding instead.
As discussed in https://lkml.org/lkml/2017/11/30/1077;
If document it in the ufshcd binding, I think it needs some codes to parse them in ufshcd.c/ufshcd-pltfrm.c, but I think these codes may not be applicable to other SOC manufacturers.
Arnd
next prev parent reply other threads:[~2018-02-23 8:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 10:14 [PATCH v8 0/5] scsi: ufs: add ufs driver code for Hisilicon Hi3660 SoC Li Wei
2018-02-13 10:14 ` [PATCH v8 1/5] scsi: ufs: add Hisilicon ufs driver code Li Wei
2018-02-13 10:14 ` [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs Li Wei
2018-02-19 3:03 ` Rob Herring
2018-02-19 9:57 ` Arnd Bergmann
2018-02-23 8:35 ` liwei (CM) [this message]
2018-03-14 2:17 ` 答复: " liwei (CM)
2018-03-23 2:22 ` liwei (CM)
2018-03-26 9:14 ` Arnd Bergmann
2018-03-26 10:26 ` 答复: " liwei (CM)
2018-03-26 10:41 ` Arnd Bergmann
2018-03-26 12:01 ` 答复: " liwei (CM)
2018-03-27 6:15 ` liwei (CM)
2018-03-28 12:49 ` Arnd Bergmann
2018-03-29 1:00 ` 答复: " liwei (CM)
2018-02-13 10:14 ` [PATCH v8 3/5] arm64: dts: add ufs dts node Li Wei
2018-03-08 16:57 ` Wei Xu
2018-02-13 10:14 ` [PATCH v8 4/5] arm64: defconfig: enable configs for Hisilicon ufs Li Wei
2018-02-13 10:14 ` [PATCH v8 5/5] arm64: defconfig: enable f2fs and squashfs Li Wei
2018-02-15 23:51 ` [PATCH v8 0/5] scsi: ufs: add ufs driver code for Hisilicon Hi3660 SoC Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1699CE87DE933F49876AD744B5DC140FA56267@DGGEMM506-MBS.china.huawei.com \
--to=liwei213@huawei.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=fengbaopeng@hisilicon.com \
--cc=gengjianfeng@hisilicon.com \
--cc=gregory.clement@free-electrons.com \
--cc=guodong.xu@linaro.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.petersen@oracle.com \
--cc=riku.voipio@linaro.org \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=treding@nvidia.com \
--cc=vinholikatti@gmail.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@huawei.com \
--cc=yamada.masahiro@socionext.com \
--cc=zangleigang@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).