From: Cengiz Can <cengiz@kernel.wtf>
To: <andy.shevchenko@gmail.com>
Cc: <dan.carpenter@oracle.com>, <devel@driverdev.osuosl.org>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<linux-media@vger.kernel.org>, <mchehab@kernel.org>,
<sakari.ailus@linux.intel.com>, Cengiz Can <cengiz@kernel.wtf>
Subject: Re: [PATCH v6] staging: atomisp: move null check to earlier point
Date: Thu, 06 Aug 2020 21:34:22 +0300 [thread overview]
Message-ID: <173c50d7bb0.2bfa.85c738e3968116fc5c0dc2de74002084@kernel.wtf> (raw)
In-Reply-To: <20200801220101.2783-1-cengiz@kernel.wtf>
Hello Andy,
Can I get some feedback on v6 please?
I hope it suits your standards this time.
Thank you
On August 2, 2020 01:02:22 Cengiz Can <cengiz@kernel.wtf> wrote:
> `find_gmin_subdev()` that returns a pointer to `struct
> gmin_subdev` can return NULL.
>
> In `gmin_v2p8_ctrl()` there's a call to this function but the
> possibility of a NULL was not checked before its being dereferenced,
> i.e.:
>
> /* Acquired here --------v */
> struct gmin_subdev *gs = find_gmin_subdev(subdev);
>
> /* v------Dereferenced here */
> if (gs->v2p8_gpio >= 0) {
> ...
> }
>
> With this change we're null checking `find_gmin_subdev()` result
> and we return an error if that's the case. We also WARN()
> for the sake of debugging.
>
> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
> Reported-by: Coverity Static Analyzer CID 1465536
> Suggested-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>
> Please do note that this change introduces a new return value to
> `gmin_v2p8_ctrl()`.
>
> [NEW] - raise a WARN and return -ENODEV if there are no subdevices.
> - return result of `gpio_request` or `gpio_direction_output`.
> - return 0 if GPIO is ON.
> - return results of `regulator_enable` or `regulator_disable`.
> - according to PMIC type, return result of `axp_regulator_set`
> or `gmin_i2c_write`.
> - return -EINVAL if unknown PMIC type.
>
> Patch Changelog:
> v4: Fix minor typo in commit message
> v5: Remove typo from email subject
> v6: Remove duplicate Signed-off-by tag
>
> drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> index 0df46a1af5f0..1ad0246764a6 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> @@ -871,6 +871,9 @@ static int gmin_v2p8_ctrl(struct v4l2_subdev *subdev,
> int on)
> int ret;
> int value;
>
> + if (WARN_ON(!gs))
> + return -ENODEV;
> +
> if (gs->v2p8_gpio >= 0) {
> pr_info("atomisp_gmin_platform: 2.8v power on GPIO %d\n",
> gs->v2p8_gpio);
> @@ -881,7 +884,7 @@ static int gmin_v2p8_ctrl(struct v4l2_subdev *subdev,
> int on)
> pr_err("V2P8 GPIO initialization failed\n");
> }
>
> - if (!gs || gs->v2p8_on == on)
> + if (gs->v2p8_on == on)
> return 0;
> gs->v2p8_on = on;
>
> --
> 2.27.0
next prev parent reply other threads:[~2020-08-06 18:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 13:56 [PATCH] staging: atomisp: move null check to earlier point Cengiz Can
2020-07-29 15:13 ` Andy Shevchenko
2020-07-30 8:45 ` Dan Carpenter
2020-07-30 8:59 ` Cengiz Can
2020-07-30 22:17 ` [PATCH v2] " Cengiz Can
2020-07-31 8:38 ` Andy Shevchenko
2020-08-01 21:51 ` [PATCH v3] " Cengiz Can
2020-08-01 21:55 ` [PATCHi v4] " Cengiz Can
2020-08-01 21:58 ` [PATCH v5] " Cengiz Can
2020-08-01 22:01 ` [PATCH v6] " Cengiz Can
2020-08-06 18:34 ` Cengiz Can [this message]
2020-08-06 18:39 ` Greg KH
2020-08-06 20:38 ` Cengiz Can
2020-08-06 22:15 ` [PATCH] " Bjorn Helgaas
2020-08-07 9:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173c50d7bb0.2bfa.85c738e3968116fc5c0dc2de74002084@kernel.wtf \
--to=cengiz@kernel.wtf \
--cc=andy.shevchenko@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).