Re: [greybus-dev] [PATCH] staging: greybus: fixed the coding style, labels should not be indented.

From: Joe Perches <joe@perches.com>
To: David Laight <David.Laight@ACULAB.COM>,
	'Alex Elder' <elder@linaro.org>,
	'Manikishan Ghantasala' <manikishanghantasala@gmail.com>,
	Alex Elder <elder@ieee.org>
Cc: Alex Elder <elder@kernel.org>,
	"greybus-dev@lists.linaro.org" <greybus-dev@lists.linaro.org>,
	"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
	Johan Hovold <johan@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [greybus-dev] [PATCH] staging: greybus: fixed the coding style, labels should not be indented.
Date: Fri, 04 Jun 2021 01:26:30 -0700	[thread overview]
Message-ID: <19651be0dc8706da34658d25195ff122f41ee7c0.camel@perches.com> (raw)
In-Reply-To: <c29b5c97f97b48c894917647915bf510@AcuMS.aculab.com>

On Fri, 2021-06-04 at 08:13 +0000, David Laight wrote:
> From: Alex Elder
> > Sent: 03 June 2021 22:55
> ...
> > Not necessarily, sizeof(bool) is implementation defined.
> > And I thought you didn't think the size of the structure
> > was very important...
> 
> It is 'implementation defined' but will be 32 bits on everything
> except an old 32bit ARM ABI.

Really? (x86-64)

$ gcc -x c -
#include <stdio.h>
#include <stdlib.h>

struct foo {
	_Bool b;
};

int main(int argc, char **argv)
{
	printf("sizeof _Bool: %zu\n", sizeof(_Bool));
	printf("sizeof struct foo: %zu\n", sizeof(struct foo));
	return 0;
}
$ ./a.out
sizeof _Bool: 1
sizeof struct foo: 1