From: shuah <shuah@kernel.org>
To: "George G. Davis" <george_davis@mentor.com>,
Jerry Hoemann <jerry.hoemann@hpe.com>,
Colin Ian King <colin.king@canonical.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH v2] selftests: watchdog: Add optional file argument
Date: Fri, 30 Aug 2019 09:12:10 -0600 [thread overview]
Message-ID: <197ee603-6ea7-a3c8-6b62-e3ba95433053@kernel.org> (raw)
In-Reply-To: <1567169597-10330-1-git-send-email-george_davis@mentor.com>
On 8/30/19 6:53 AM, George G. Davis wrote:
> Some systems have multiple watchdog devices where the first device
> registered is assigned to the /dev/watchdog device file. In order
> to test other watchdog devices, add an optional file argument for
> selecting non-default watchdog devices for testing.
>
> Tested-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> Signed-off-by: George G. Davis <george_davis@mentor.com>
> ---
> v1:
> - https://lkml.org/lkml/2019/8/29/16
> v2:
> - Update printf for ENOENT case based on report from Eugeniu Rosca
> ---
> tools/testing/selftests/watchdog/watchdog-test.c | 19 ++++++++++++++++---
> 1 file changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/watchdog/watchdog-test.c b/tools/testing/selftests/watchdog/watchdog-test.c
> index c2333c78cf04..9f17cae61007 100644
> --- a/tools/testing/selftests/watchdog/watchdog-test.c
> +++ b/tools/testing/selftests/watchdog/watchdog-test.c
> @@ -19,7 +19,7 @@
>
> int fd;
> const char v = 'V';
> -static const char sopts[] = "bdehp:t:Tn:NL";
> +static const char sopts[] = "bdehp:t:Tn:NLf:";
> static const struct option lopts[] = {
> {"bootstatus", no_argument, NULL, 'b'},
> {"disable", no_argument, NULL, 'd'},
> @@ -31,6 +31,7 @@ static const struct option lopts[] = {
> {"pretimeout", required_argument, NULL, 'n'},
> {"getpretimeout", no_argument, NULL, 'N'},
> {"gettimeleft", no_argument, NULL, 'L'},
> + {"file", required_argument, NULL, 'f'},
> {NULL, no_argument, NULL, 0x0}
> };
>
> @@ -69,6 +70,7 @@ static void term(int sig)
> static void usage(char *progname)
> {
> printf("Usage: %s [options]\n", progname);
> + printf(" -f, --file Open watchdog device file (default is /dev/watchdog)\n");
Can you split this line into two printf's. Checkpatch doesn't like
it.
printf(" -f, --file Open watchdog device file\n");
A second one below for default.
On a separate note, I wish this usage block uses \t instead of spacing
things out.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-08-30 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 12:53 [PATCH v2] selftests: watchdog: Add optional file argument George G. Davis
2019-08-30 13:38 ` Eugeniu Rosca
2019-08-30 14:26 ` George G. Davis
2019-08-30 15:12 ` shuah [this message]
2019-08-30 16:13 ` George G. Davis
2019-08-30 16:20 ` shuah
2019-08-30 19:36 ` George G. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=197ee603-6ea7-a3c8-6b62-e3ba95433053@kernel.org \
--to=shuah@kernel.org \
--cc=colin.king@canonical.com \
--cc=erosca@de.adit-jv.com \
--cc=george_davis@mentor.com \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).