From: Randy Dunlap <rdunlap@infradead.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: linux-next: Tree for Sep 10 (drivers/media/pci/ttpci/dvb-ttpci)
Date: Fri, 11 Sep 2020 08:52:45 -0700 [thread overview]
Message-ID: <1bf30e26-cd8d-a2dd-aaf3-97c2dbc1875a@infradead.org> (raw)
In-Reply-To: <20200911093156.15282b69@coco.lan>
On 9/11/20 12:31 AM, Mauro Carvalho Chehab wrote:
> Hi Randy,
>
> Em Thu, 10 Sep 2020 09:02:35 -0700
> Randy Dunlap <rdunlap@infradead.org> escreveu:
>
>> On 9/10/20 12:42 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20200909:
>>>
>>
>>
>> on i386:
>>
>> ERROR: modpost: "__floatunsidf" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
>> ERROR: modpost: "__ltdf2" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
>>
>>
>> Full randconfig file is attached.
>
> I was unable to reproduce it here with the .config file you sent.
>
> I suspect that the only difference is the compiler version. Here, I'm
> using:
>
> gcc (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008
>
> While you're using:
>
> gcc (SUSE Linux) 7.5.0
>
> Yet, the only patch that could possibly have affected it is
> this changeset 13c129066845 ("media: av7110_v4l: avoid a typecast").
>
> It sounds to me that gcc 7.5.0 only does the right math at compile
> time if there is a typecast. Could you please check if the enclosed
> patch fixes it?
Hi Mauro,
Yes, this fixes the build for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Thanks,
> Mauro
>
> [PATCH] media: av7110: don't do float point math
>
> It sounds that earlier versions of GCC have troubles when
> doing const math at compile time, if no typecast is used:
>
> on i386:
> ERROR: modpost: "__floatunsidf" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
> ERROR: modpost: "__ltdf2" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
>
> The warning was generated on gcc (SUSE Linux) 7.5.0.
> Gcc 9.2 compiles it fine.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> diff --git a/drivers/media/pci/ttpci/av7110_v4l.c b/drivers/media/pci/ttpci/av7110_v4l.c
> index 6d9c908be713..c89f536f699c 100644
> --- a/drivers/media/pci/ttpci/av7110_v4l.c
> +++ b/drivers/media/pci/ttpci/av7110_v4l.c
> @@ -160,9 +160,9 @@ static int ves1820_set_tv_freq(struct saa7146_dev *dev, u32 freq)
> buf[1] = div & 0xff;
> buf[2] = 0x8e;
>
> - if (freq < 16U * 168.25)
> + if (freq < 16U * 16825 / 100)
> config = 0xa0;
> - else if (freq < 16U * 447.25)
> + else if (freq < 16U * 44725 / 100)
> config = 0x90;
> else
> config = 0x30;
>
--
~Randy
next prev parent reply other threads:[~2020-09-11 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 7:42 linux-next: Tree for Sep 10 Stephen Rothwell
2020-09-10 16:02 ` linux-next: Tree for Sep 10 (drivers/media/pci/ttpci/dvb-ttpci) Randy Dunlap
2020-09-11 7:31 ` Mauro Carvalho Chehab
2020-09-11 15:52 ` Randy Dunlap [this message]
2020-09-11 16:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bf30e26-cd8d-a2dd-aaf3-97c2dbc1875a@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).