From: Yinan Liu <yinan@linux.alibaba.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mark-pk.tsai@mediatek.com, peterz@infradead.org,
mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scripts: ftrace - move the sort-processing in ftrace_init to compile time
Date: Sat, 9 Oct 2021 10:56:40 +0800 [thread overview]
Message-ID: <1d069626-1aed-6244-b932-7853e832eb70@linux.alibaba.com> (raw)
In-Reply-To: <20211008194821.3b6a18a4@oasis.local.home>
On 2021/10/9 上午7:48, Steven Rostedt wrote:
> On Sun, 3 Oct 2021 21:42:10 +0800
> Yinan Liu <yinan@linux.alibaba.com> wrote:
>
>> Sorry for my slow progress . I have encountered some problems with the
>> sorting
>> of the module's mcount in compile time. The .ko file will be relocated
>> after insmod
>> or modprobe, most of the mcount relocation is based on .text section,
>> but there are
>> also a small part of mcount relocation based on .init.text section such
>> as module_init().
>> The loading position of .init.text and .text does not seem to be in a
>> definite order.
>
> Right, there's no guarantee that the .text portion of a module is
> placed before or after the .init.text portion.
yes.
>
>>
>> For example, when I insmod ip_tables.ko twice, the front and back
>> positions of init.text
>> and .text are different, so we cannot sort the mcounts in the two
>> sections, which makes
>> the mcount sorting in the module meaningless.
>>
>> What is your opinion on this?
>
> Probably just keep the sorting algorithm in the kernel and take place
> on module load.
>
> If you still want to sort at compile time, then do the sort for .init
> functions separate from the .text ones, and have a way to extract this
> information (shouldn't be too hard) in the kernel at module load, and
> then just swap the init and text functions if they were added in the
> reverse order that was expect.
>
> The functions in .init will either be before all the functions in .text
> or after. They wont be intermingled. Thus, if they are both sorted,
> then they are placed correctly or the two groups of functions need to
> be switched. No other sorting should be necessary.
Thanks so much! I see. And I will have a try.
>
> -- Steve
>
Best regards!
-- Yinan liu
next prev parent reply other threads:[~2021-10-09 2:56 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 13:50 [PATCH 0/2] ftrace: improve ftrace during compiling Yinan Liu
2021-09-11 13:50 ` [PATCH 1/2] scripts: ftrace - move the sort-processing in ftrace_init to compile time Yinan Liu
2021-09-11 13:59 ` Steven Rostedt
2021-10-03 13:42 ` Yinan Liu
2021-10-08 23:48 ` Steven Rostedt
2021-10-09 2:56 ` Yinan Liu [this message]
2021-10-25 13:20 ` Yinan Liu
2021-10-25 15:00 ` Steven Rostedt
2021-09-11 13:50 ` [PATCH 2/2] scripts: ftrace - move the nop-processing " Yinan Liu
2021-09-11 14:12 ` Steven Rostedt
2021-09-11 15:28 ` Yinan Liu
2021-09-11 16:07 ` Peter Zijlstra
2021-09-11 14:33 ` Peter Zijlstra
2021-09-11 17:15 ` kernel test robot
2021-09-11 18:04 ` kernel test robot
2021-11-16 2:49 ` [PATCH v2 0/2] ftrace optimization at " Yinan Liu
2021-11-16 2:49 ` [PATCH v2 1/2] scripts: ftrace - move the sort-processing in ftrace_init to " Yinan Liu
2021-11-16 8:07 ` Peter Zijlstra
2021-11-16 12:42 ` Yinan Liu
2021-11-16 13:05 ` Peter Zijlstra
2021-11-16 14:46 ` Yinan Liu
2021-11-17 13:34 ` kernel test robot
2021-11-16 2:49 ` [PATCH v2 2/2] scripts: ftrace - move the nop-processing " Yinan Liu
2021-11-16 8:10 ` Peter Zijlstra
2021-11-16 12:51 ` Yinan Liu
2021-11-16 13:07 ` Steven Rostedt
2021-11-16 15:02 ` Yinan Liu
2021-11-16 16:06 ` Steven Rostedt
2021-11-22 13:43 ` [PATCH v3] scripts: ftrace - move the sort-processing " Yinan Liu
2021-11-23 10:54 ` [PATCH v4] ftrace sorting optimization changelog Yinan Liu
2021-11-23 10:54 ` [PATCH v4] scripts: ftrace - move the sort-processing in ftrace_init to compile time Yinan Liu
2021-11-29 2:13 ` Yinan Liu
2021-11-29 3:51 ` Steven Rostedt
2021-11-29 6:52 ` Yinan Liu
2021-11-30 17:08 ` Steven Rostedt
2021-12-01 5:32 ` [PATCH v5 0/2] ftrace sorting optimization changelog Yinan Liu
2021-12-01 5:32 ` [PATCH v5 1/2] scripts: ftrace - move the sort-processing in ftrace_init to compile time Yinan Liu
2021-12-01 21:45 ` Steven Rostedt
2021-12-05 12:35 ` [scripts] 12955fb1c5: kernel-selftests.livepatch.test-ftrace.sh.fail kernel test robot
2021-12-01 5:32 ` [PATCH v5 2/2] script/sorttable: code style improvements Yinan Liu
2021-12-02 2:16 ` [PATCH v6 0/2] ftrace sorting optimization changelog Yinan Liu
2021-12-02 2:16 ` [PATCH v6 1/2] scripts: ftrace - move the sort-processing in ftrace_init Yinan Liu
2021-12-02 17:58 ` Steven Rostedt
2021-12-05 12:45 ` Masami Hiramatsu
2021-12-06 20:18 ` Steven Rostedt
2021-12-07 1:29 ` Yinan Liu
2021-12-02 2:16 ` [PATCH v6 2/2] script/sorttable: code style improvements Yinan Liu
2021-12-02 15:30 ` [PATCH v6 0/2] ftrace sorting optimization changelog Peter Zijlstra
2021-12-07 15:13 ` [PATCH v7 0/2] ftrace sorting optimization Yinan Liu
2021-12-07 15:13 ` [PATCH v7 1/2] scripts: ftrace - move the sort-processing in ftrace_init Yinan Liu
2021-12-11 14:50 ` Steven Rostedt
2021-12-07 15:13 ` [PATCH v7 2/2] script/sorttable: code style improvements Yinan Liu
2021-12-12 11:33 ` [PATCH v8 0/1] change log Yinan Liu
2021-12-12 11:33 ` [PATCH v8] scripts: ftrace - move the sort-processing in ftrace_init Yinan Liu
2022-01-21 9:46 ` Sven Schnelle
2022-01-21 10:42 ` Heiko Carstens
2022-01-21 11:14 ` Sven Schnelle
2022-01-21 11:29 ` Sven Schnelle
2022-01-21 18:11 ` Steven Rostedt
2022-01-22 9:17 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d069626-1aed-6244-b932-7853e832eb70@linux.alibaba.com \
--to=yinan@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark-pk.tsai@mediatek.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).