linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Wangnan (F)" <wangnan0@huawei.com>
To: Joe Stringer <joe@ovn.org>, <linux-kernel@vger.kernel.org>
Cc: <ast@fb.com>, <daniel@iogearbox.net>, <acme@kernel.org>,
	<netdev@vger.kernel.org>
Subject: Re: [PATCHv3 perf/core 2/7] tools lib bpf: use __u32 from linux/types.h
Date: Fri, 9 Dec 2016 11:28:19 +0800	[thread overview]
Message-ID: <1d2b9c76-32cf-f810-22f2-00dc1c679260@huawei.com> (raw)
In-Reply-To: <20161209024620.31660-3-joe@ovn.org>



On 2016/12/9 10:46, Joe Stringer wrote:
> Fixes the following issue when building without access to 'u32' type:
>
> ./tools/lib/bpf/bpf.h:27:23: error: unknown type name ‘u32’
>
> Signed-off-by: Joe Stringer <joe@ovn.org>
> ---
> v3: Split from "tools lib bpf: Sync with samples/bpf/libbpf"
> ---
>   tools/lib/bpf/bpf.c | 4 ++--
>   tools/lib/bpf/bpf.h | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)

Acked-by: Wang Nan <wangnan0@huawei.com>

> diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
> index 8143536b462a..89e8e8e5b60e 100644
> --- a/tools/lib/bpf/bpf.c
> +++ b/tools/lib/bpf/bpf.c
> @@ -70,7 +70,7 @@ int bpf_create_map(enum bpf_map_type map_type, int key_size,
>   
>   int bpf_load_program(enum bpf_prog_type type, struct bpf_insn *insns,
>   		     size_t insns_cnt, char *license,
> -		     u32 kern_version, char *log_buf, size_t log_buf_sz)
> +		     __u32 kern_version, char *log_buf, size_t log_buf_sz)
>   {
>   	int fd;
>   	union bpf_attr attr;
> @@ -98,7 +98,7 @@ int bpf_load_program(enum bpf_prog_type type, struct bpf_insn *insns,
>   }
>   
>   int bpf_map_update_elem(int fd, void *key, void *value,
> -			u64 flags)
> +			__u64 flags)
>   {
>   	union bpf_attr attr;
>   
> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
> index 253c3dbb06b4..61130170a6ad 100644
> --- a/tools/lib/bpf/bpf.h
> +++ b/tools/lib/bpf/bpf.h
> @@ -30,11 +30,11 @@ int bpf_create_map(enum bpf_map_type map_type, int key_size, int value_size,
>   #define BPF_LOG_BUF_SIZE 65536
>   int bpf_load_program(enum bpf_prog_type type, struct bpf_insn *insns,
>   		     size_t insns_cnt, char *license,
> -		     u32 kern_version, char *log_buf,
> +		     __u32 kern_version, char *log_buf,
>   		     size_t log_buf_sz);
>   
>   int bpf_map_update_elem(int fd, void *key, void *value,
> -			u64 flags);
> +			__u64 flags);
>   
>   int bpf_map_lookup_elem(int fd, void *key, void *value);
>   int bpf_map_delete_elem(int fd, void *key);

  reply	other threads:[~2016-12-09  3:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09  2:46 [PATCHv3 perf/core 0/7] Reuse libbpf from samples/bpf Joe Stringer
2016-12-09  2:46 ` [PATCHv3 perf/core 1/7] tools lib bpf: Sync {tools,}/include/uapi/linux/bpf.h Joe Stringer
2016-12-20 19:26   ` [tip:perf/urgent] " tip-bot for Joe Stringer
2016-12-09  2:46 ` [PATCHv3 perf/core 2/7] tools lib bpf: use __u32 from linux/types.h Joe Stringer
2016-12-09  3:28   ` Wangnan (F) [this message]
2016-12-20 19:27   ` [tip:perf/urgent] " tip-bot for Joe Stringer
2016-12-09  2:46 ` [PATCHv3 perf/core 3/7] tools lib bpf: Add flags to bpf_create_map() Joe Stringer
2016-12-09  3:36   ` Wangnan (F)
2016-12-09 14:27     ` Arnaldo Carvalho de Melo
2016-12-20 19:27   ` [tip:perf/urgent] " tip-bot for Joe Stringer
2016-12-09  2:46 ` [PATCHv3 perf/core 4/7] samples/bpf: Make samples more libbpf-centric Joe Stringer
2016-12-09  2:46 ` [PATCHv3 perf/core 5/7] samples/bpf: Switch over to libbpf Joe Stringer
2016-12-09  5:04   ` Wangnan (F)
2016-12-09  5:18     ` Wangnan (F)
2016-12-09 17:59       ` Joe Stringer
2016-12-09  2:46 ` [PATCHv3 perf/core 6/7] samples/bpf: Remove perf_event_open() declaration Joe Stringer
2016-12-09 14:59   ` Arnaldo Carvalho de Melo
2016-12-20 19:32   ` [tip:perf/urgent] " tip-bot for Joe Stringer
2016-12-09  2:46 ` [PATCHv3 perf/core 7/7] samples/bpf: Move open_raw_sock to separate header Joe Stringer
2016-12-20 19:33   ` [tip:perf/urgent] " tip-bot for Joe Stringer
2016-12-09 15:09 ` [PATCHv3 perf/core 0/7] Reuse libbpf from samples/bpf Arnaldo Carvalho de Melo
2016-12-09 15:30   ` Daniel Borkmann
2016-12-14 13:25     ` Arnaldo Carvalho de Melo
2016-12-14 14:55       ` Arnaldo Carvalho de Melo
2016-12-14 22:46         ` Joe Stringer
2016-12-15 14:33           ` Arnaldo Carvalho de Melo
2016-12-15 15:35             ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d2b9c76-32cf-f810-22f2-00dc1c679260@huawei.com \
    --to=wangnan0@huawei.com \
    --cc=acme@kernel.org \
    --cc=ast@fb.com \
    --cc=daniel@iogearbox.net \
    --cc=joe@ovn.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).