From: Tero Kristo <t-kristo@ti.com>
To: Suman Anna <s-anna@ti.com>, <bjorn.andersson@linaro.org>,
<ohad@wizery.com>, <linux-remoteproc@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <mathieu.poirier@linaro.org>,
<linux-omap@vger.kernel.org>, Rob Herring <robh@kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [RESEND PATCHv4 01/14] dt-bindings: remoteproc: Add OMAP remoteproc bindings
Date: Thu, 16 Jan 2020 09:51:18 +0200 [thread overview]
Message-ID: <1d4597f7-9e28-8b16-7679-c8abd291346d@ti.com> (raw)
In-Reply-To: <f4ac066a-e5ee-f888-42bb-3f6d444747ee@ti.com>
On 08/01/2020 18:49, Suman Anna wrote:
> Hi Tero,
>
> On 1/2/20 7:25 AM, Tero Kristo wrote:
>> From: Suman Anna <s-anna@ti.com>
>>
>> Add the device tree bindings document for the IPU and DSP
>> remote processor devices on OMAP4+ SoCs.
>>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> [t-kristo@ti.com: converted to schema]
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> ---
>> v4: added ti,bootreg-shift and ti,autosuspend-delay properties
>
> You missed out on my v3 comment on the firmware-name on Example 2. Can
> you please address it when you post the next version?
I don't think I missed it, but you never told what is the actual name to
use there. Firmware name generally does not matter, as user can provide
whatever he wants via DT now.
-Tero
>
>>
>> .../remoteproc/ti,omap-remoteproc.yaml | 329 ++++++++++++++++++
>> 1 file changed, 329 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml
>> new file mode 100644
>> index 000000000000..f53d58efaae3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,omap-remoteproc.yaml
>
> [snip]
>
>> + - |+
>> +
>> + //Example 2: OMAP5 IPU
>> +
>> + /* IPU Reserved Memory node */
>> + #include <dt-bindings/clock/omap5.h>
>> + reserved-memory {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + ipu_memory_region: ipu-memory@95800000 {
>> + compatible = "shared-dma-pool";
>> + reg = <0 0x95800000 0 0x3800000>;
>> + reusable;
>> + };
>> + };
>> +
>> + /* IPU node */
>> + ocp {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + ipu: ipu@55020000 {
>> + compatible = "ti,omap5-ipu";
>> + reg = <0x55020000 0x10000>;
>> + reg-names = "l2ram";
>> + iommus = <&mmu_ipu>;
>> + mboxes = <&mailbox &mbox_ipu>;
>> + memory-region = <&ipu_memory_region>;
>> + ti,timers = <&timer3>, <&timer4>;
>> + ti,watchdog-timers = <&timer9>, <&timer11>;
>> + clocks = <&ipu_clkctrl OMAP5_MMU_IPU_CLKCTRL 0>;
>> + resets = <&prm_core 2>;
>> + firmware-name = "omap5-ipu-fw.xem";
>> + };
>> + };
>
> regards
> Suman
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-01-16 7:51 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 13:18 [PATCHv4 00/14] remoteproc: updates for omap remoteproc support Tero Kristo
2020-01-02 13:18 ` [PATCHv4 01/14] dt-bindings: remoteproc: Add OMAP remoteproc bindings Tero Kristo
2020-01-02 13:25 ` [RESEND PATCHv4 " Tero Kristo
2020-01-03 23:38 ` Rob Herring
2020-01-07 11:01 ` Tero Kristo
2020-01-07 15:48 ` Rob Herring
2020-01-08 16:49 ` Suman Anna
2020-01-16 7:51 ` Tero Kristo [this message]
2020-01-16 14:00 ` Tero Kristo
2020-01-02 13:26 ` [PATCHv4 " Tero Kristo
2020-01-02 13:18 ` [PATCHv4 02/14] remoteproc/omap: Add device tree support Tero Kristo
2020-01-08 17:55 ` Suman Anna
2020-01-09 8:53 ` Tero Kristo
2020-01-02 13:18 ` [PATCHv4 03/14] remoteproc/omap: Add a sanity check for DSP boot address alignment Tero Kristo
2020-01-02 13:18 ` [PATCHv4 04/14] remoteproc/omap: Add support to parse internal memories from DT Tero Kristo
2020-01-08 18:05 ` Suman Anna
2020-01-09 9:12 ` Tero Kristo
2020-01-09 17:19 ` Suman Anna
2020-01-02 13:18 ` [PATCHv4 05/14] remoteproc/omap: Add the rproc ops .da_to_va() implementation Tero Kristo
2020-01-02 13:18 ` [PATCHv4 06/14] remoteproc/omap: Initialize and assign reserved memory node Tero Kristo
2020-01-07 13:37 ` Andrew F. Davis
2020-01-07 14:25 ` Tero Kristo
2020-01-07 14:37 ` Andrew F. Davis
2020-01-08 17:22 ` Suman Anna
2020-01-02 13:18 ` [PATCHv4 07/14] remoteproc/omap: Add support for DRA7xx remote processors Tero Kristo
2020-01-08 19:39 ` Suman Anna
2020-01-15 12:34 ` Tero Kristo
2020-01-02 13:18 ` [PATCHv4 08/14] remoteproc/omap: remove the platform_data header Tero Kristo
2020-01-08 19:44 ` Suman Anna
2020-01-15 12:58 ` Tero Kristo
2020-01-02 13:18 ` [PATCHv4 09/14] remoteproc/omap: Check for undefined mailbox messages Tero Kristo
2020-01-02 13:18 ` [PATCHv4 10/14] remoteproc/omap: Request a timer(s) for remoteproc usage Tero Kristo
2020-01-08 21:30 ` Suman Anna
2020-01-02 13:18 ` [PATCHv4 11/14] remoteproc/omap: add support for system suspend/resume Tero Kristo
2020-01-08 19:57 ` Suman Anna
2020-01-08 21:42 ` Suman Anna
2020-01-15 13:20 ` Tero Kristo
2020-01-02 13:18 ` [PATCHv4 12/14] remoteproc/omap: add support for runtime auto-suspend/resume Tero Kristo
2020-01-02 13:18 ` [PATCHv4 13/14] remoteproc/omap: report device exceptions and trigger recovery Tero Kristo
2020-01-02 13:18 ` [PATCHv4 14/14] remoteproc/omap: add watchdog functionality for remote processors Tero Kristo
2020-01-08 20:11 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d4597f7-9e28-8b16-7679-c8abd291346d@ti.com \
--to=t-kristo@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=robh@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).