From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
ranjani.sridharan@linux.intel.com, hui.wang@canonical.com,
broonie@kernel.org, srinivas.kandagatla@linaro.org,
jank@cadence.com, sanyog.r.kale@intel.com,
rander.wang@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH 1/7] soundwire: bus: use sdw_update_no_pm when initializing a device
Date: Sat, 5 Dec 2020 08:59:01 -0600 [thread overview]
Message-ID: <1db93c2e-3c87-bc5e-ddeb-56424870b897@linux.intel.com> (raw)
In-Reply-To: <20201205074508.GQ8403@vkoul-mobl>
Thanks for the review Vinod.
On 12/5/20 1:45 AM, Vinod Koul wrote:
> On 03-12-20, 04:46, Bard Liao wrote:
>> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>>
>> When a Slave device is resumed, it may resume the bus and restart the
>> enumeration. During that process, we absolutely don't want to call
>> regular read/write routines which will wait for the resume to
>> complete, otherwise a deadlock occurs.
>>
>> Fixes: 60ee9be25571 ('soundwire: bus: add PM/no-PM versions of read/write functions')
>
> Change looks okay, but not sure why this is a fix for adding no pm
> version?
when we added the no_pm version, we missed the two cases below where
sdw_update() was used and that creates a deadlock. To me that's a
conceptual bug, we didn't fully use the no_pm versions, hence the Fixes tag.
It's ok to remove the tag if you don't think it's useful/relevant, what
matters is that we agree on the content.
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
>> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
>> ---
>> drivers/soundwire/bus.c | 16 ++++++++++++++--
>> 1 file changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
>> index d1e8c3a54976..60c42508c6c6 100644
>> --- a/drivers/soundwire/bus.c
>> +++ b/drivers/soundwire/bus.c
>> @@ -489,6 +489,18 @@ sdw_read_no_pm(struct sdw_slave *slave, u32 addr)
>> return buf;
>> }
>>
>> +static int sdw_update_no_pm(struct sdw_slave *slave, u32 addr, u8 mask, u8 val)
>> +{
>> + int tmp;
>> +
>> + tmp = sdw_read_no_pm(slave, addr);
>> + if (tmp < 0)
>> + return tmp;
>> +
>> + tmp = (tmp & ~mask) | val;
>> + return sdw_write_no_pm(slave, addr, tmp);
>> +}
>> +
>> /**
>> * sdw_nread() - Read "n" contiguous SDW Slave registers
>> * @slave: SDW Slave
>> @@ -1256,7 +1268,7 @@ static int sdw_initialize_slave(struct sdw_slave *slave)
>> val = slave->prop.scp_int1_mask;
>>
>> /* Enable SCP interrupts */
>> - ret = sdw_update(slave, SDW_SCP_INTMASK1, val, val);
>> + ret = sdw_update_no_pm(slave, SDW_SCP_INTMASK1, val, val);
>> if (ret < 0) {
>> dev_err(slave->bus->dev,
>> "SDW_SCP_INTMASK1 write failed:%d\n", ret);
>> @@ -1271,7 +1283,7 @@ static int sdw_initialize_slave(struct sdw_slave *slave)
>> val = prop->dp0_prop->imp_def_interrupts;
>> val |= SDW_DP0_INT_PORT_READY | SDW_DP0_INT_BRA_FAILURE;
>>
>> - ret = sdw_update(slave, SDW_DP0_INTMASK, val, val);
>> + ret = sdw_update_no_pm(slave, SDW_DP0_INTMASK, val, val);
>> if (ret < 0)
>> dev_err(slave->bus->dev,
>> "SDW_DP0_INTMASK read failed:%d\n", ret);
>> --
>> 2.17.1
>
next prev parent reply other threads:[~2020-12-05 18:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 20:46 [PATCH 0/7] soundwire/regmap: use _no_pm routines Bard Liao
2020-12-02 20:46 ` [PATCH 1/7] soundwire: bus: use sdw_update_no_pm when initializing a device Bard Liao
2020-12-05 7:45 ` Vinod Koul
2020-12-05 14:59 ` Pierre-Louis Bossart [this message]
2020-12-07 4:43 ` Vinod Koul
2020-12-07 15:31 ` Pierre-Louis Bossart
2020-12-08 4:56 ` Vinod Koul
2020-12-02 20:46 ` [PATCH 2/7] soundwire: bus: use sdw_write_no_pm when setting the bus scale registers Bard Liao
2020-12-02 20:46 ` [PATCH 3/7] soundwire: bus: use no_pm IO routines for all interrupt handling Bard Liao
2020-12-02 20:46 ` [PATCH 4/7] soundwire/regmap: use _no_pm functions in regmap_read/write Bard Liao
2020-12-05 7:45 ` Vinod Koul
2020-12-05 14:43 ` Pierre-Louis Bossart
2020-12-02 20:46 ` [PATCH 5/7] regmap: sdw: use no_pm routines for SoundWire 1.2 MBQ Bard Liao
2020-12-05 7:46 ` Vinod Koul
2020-12-05 14:52 ` Pierre-Louis Bossart
2020-12-05 16:31 ` Greg KH
2020-12-07 4:47 ` Vinod Koul
2020-12-02 20:46 ` [PATCH 6/7] soundwire: bus: fix confusion on device used by pm_runtime Bard Liao
2020-12-02 20:46 ` [PATCH 7/7] soundwire: bus: clarify dev_err/dbg device references Bard Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1db93c2e-3c87-bc5e-ddeb-56424870b897@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).