From: Steven Price <steven.price@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Suzuki K Pouloze" <suzuki.poulose@arm.com>,
linux-doc@vger.kernel.org, "Russell King" <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, "James Morse" <james.morse@arm.com>,
linux-arm-kernel@lists.infradead.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Will Deacon" <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
"Julien Thierry" <julien.thierry.kdev@gmail.com>
Subject: Re: [PATCH 3/9] KVM: arm64: Implement PV_FEATURES call
Date: Mon, 5 Aug 2019 14:14:08 +0100 [thread overview]
Message-ID: <1e0a03b4-1fb6-cbe2-fb7a-8ed39341a187@arm.com> (raw)
In-Reply-To: <20190803122124.7700f700@why>
On 03/08/2019 12:21, Marc Zyngier wrote:
> On Fri, 2 Aug 2019 15:50:11 +0100
> Steven Price <steven.price@arm.com> wrote:
>
>> This provides a mechanism for querying which paravirtualized features
>> are available in this hypervisor.
>>
>> Also add the header file which defines the ABI for the paravirtualized
>> clock features we're about to add.
>>
>> Signed-off-by: Steven Price <steven.price@arm.com>
>> ---
>> arch/arm64/include/asm/pvclock-abi.h | 20 ++++++++++++++++++++
>> include/linux/arm-smccc.h | 14 ++++++++++++++
>> virt/kvm/arm/hypercalls.c | 9 +++++++++
>> 3 files changed, 43 insertions(+)
>> create mode 100644 arch/arm64/include/asm/pvclock-abi.h
>>
>> diff --git a/arch/arm64/include/asm/pvclock-abi.h b/arch/arm64/include/asm/pvclock-abi.h
>> new file mode 100644
>> index 000000000000..1f7cdc102691
>> --- /dev/null
>> +++ b/arch/arm64/include/asm/pvclock-abi.h
>> @@ -0,0 +1,20 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/* Copyright (C) 2019 Arm Ltd. */
>> +
>> +#ifndef __ASM_PVCLOCK_ABI_H
>> +#define __ASM_PVCLOCK_ABI_H
>> +
>> +/* The below structures and constants are defined in ARM DEN0057A */
>> +
>> +struct pvclock_vcpu_stolen_time_info {
>> + __le32 revision;
>> + __le32 attributes;
>> + __le64 stolen_time;
>> + /* Structure must be 64 byte aligned, pad to that size */
>> + u8 padding[48];
>> +} __packed;
>> +
>> +#define PV_VM_TIME_NOT_SUPPORTED -1
>
> Isn't the intent for this to be the same value as
> SMCCC_RET_NOT_SUPPORTED?
Yes it is, I guess there's not much point defining it again.
>> +#define PV_VM_TIME_INVALID_PARAMETERS -2
>
> It overlaps with SMCCC_RET_NOT_REQUIRED. Is that a problem? Should we
> consider a spec change for this?
Actually INVALID_PARAMETERS is only for Live Physical Time, since we're
not implementing it here, this can go as well.
Thanks,
Steve
next prev parent reply other threads:[~2019-08-05 13:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 14:50 [PATCH 0/9] arm64: Stolen time support Steven Price
2019-08-02 14:50 ` [PATCH 1/9] KVM: arm64: Document PV-time interface Steven Price
2019-08-03 11:13 ` Marc Zyngier
2019-08-05 13:06 ` Steven Price
2019-08-05 3:23 ` Zenghui Yu
2019-08-05 13:06 ` Steven Price
2019-08-05 16:40 ` Christophe de Dinechin
2019-08-07 13:21 ` Steven Price
[not found] ` <9F77FA64-C71B-4025-A58D-3AC07E6688DE@dinechin.org>
2019-08-07 15:26 ` Steven Price
2019-08-02 14:50 ` [PATCH 2/9] KVM: arm/arm64: Factor out hypercall handling from PSCI code Steven Price
2019-08-02 14:50 ` [PATCH 3/9] KVM: arm64: Implement PV_FEATURES call Steven Price
2019-08-03 11:21 ` Marc Zyngier
2019-08-05 13:14 ` Steven Price [this message]
2019-08-02 14:50 ` [PATCH 4/9] KVM: arm64: Support stolen time reporting via shared structure Steven Price
2019-08-03 11:55 ` Marc Zyngier
2019-08-05 14:09 ` Steven Price
2019-08-03 17:58 ` Marc Zyngier
2019-08-03 18:13 ` Marc Zyngier
2019-08-05 14:18 ` Steven Price
2019-08-02 14:50 ` [PATCH 5/9] KVM: Allow kvm_device_ops to be const Steven Price
2019-08-02 14:50 ` [PATCH 6/9] KVM: arm64: Provide a PV_TIME device to user space Steven Price
2019-08-03 12:51 ` Marc Zyngier
2019-08-03 17:34 ` Marc Zyngier
2019-08-07 13:39 ` Steven Price
2019-08-07 13:51 ` Marc Zyngier
2019-08-05 16:10 ` Steven Price
2019-08-05 16:28 ` Marc Zyngier
2019-08-02 14:50 ` [PATCH 7/9] arm/arm64: Provide a wrapper for SMCCC 1.1 calls Steven Price
2019-08-05 10:03 ` Will Deacon
2019-08-02 14:50 ` [PATCH 8/9] arm/arm64: Make use of the SMCCC 1.1 wrapper Steven Price
2019-08-02 14:50 ` [PATCH 9/9] arm64: Retrieve stolen time as paravirtualized guest Steven Price
2019-08-04 9:53 ` Marc Zyngier
2019-08-08 15:29 ` Steven Price
2019-08-08 15:49 ` Marc Zyngier
2019-08-09 13:51 ` Zenghui Yu
2019-08-12 10:39 ` Steven Price
2019-08-13 6:06 ` Zenghui Yu
2019-08-03 18:05 ` [PATCH 0/9] arm64: Stolen time support Marc Zyngier
2019-08-05 13:06 ` Steven Price
2019-08-05 13:26 ` Marc Zyngier
2019-08-14 13:02 ` Alexander Graf
[not found] ` <8636i3omnd.wl-maz@kernel.org>
2019-08-14 14:52 ` [UNVERIFIED SENDER] " Alexander Graf
2019-08-16 10:23 ` Steven Price
2020-07-21 3:26 ` zhukeqian
2020-07-27 10:48 ` Steven Price
2020-07-29 2:57 ` zhukeqian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e0a03b4-1fb6-cbe2-fb7a-8ed39341a187@arm.com \
--to=steven.price@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).