From: Paolo Bonzini <pbonzini@redhat.com>
To: Ben Gardon <bgardon@google.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Peter Xu <peterx@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Peter Shier <pshier@google.com>,
Junaid Shahid <junaids@google.com>,
Jim Mattson <jmattson@google.com>,
Yulei Zhang <yulei.kernel@gmail.com>,
Wanpeng Li <kernellwp@gmail.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>
Subject: Re: [PATCH v2 7/7] KVM: x86/mmu: Lazily allocate memslot rmaps
Date: Tue, 4 May 2021 22:22:53 +0200 [thread overview]
Message-ID: <1e50ae22-16a3-c43d-594a-a20d2ea3caa5@redhat.com> (raw)
In-Reply-To: <20210429211833.3361994-8-bgardon@google.com>
On 29/04/21 23:18, Ben Gardon wrote:
> + /*
> + * If set, the rmap should be allocated for any newly created or
> + * modified memslots. If allocating rmaps lazily, this may be set
> + * before the rmaps are allocated for existing memslots, but
> + * shadow_mmu_active will not be set until after the rmaps are fully
> + * allocated.
> + */
> + bool alloc_memslot_rmaps;
Let's remove the whole sentence starting with "If allocating rmaps
lazily". The part about shadow_mmu_active should go there, while the
rest is pointless as long as we just say that this flag will be accessed
only under slots_arch_lock.
(Regarding shadow_mmu_active, I think I know what Sean will be
suggesting because I had a similar thought and decided it introduced
extra unnecessary complication... but maybe not, so let's see what he says).
Paolo
next prev parent reply other threads:[~2021-05-04 20:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 21:18 [PATCH v2 0/7] Lazily allocate memslot rmaps Ben Gardon
2021-04-29 21:18 ` [PATCH v2 1/7] KVM: x86/mmu: Track if shadow MMU active Ben Gardon
2021-05-03 13:42 ` Paolo Bonzini
2021-05-04 17:26 ` Ben Gardon
2021-05-04 20:18 ` Paolo Bonzini
2021-05-04 19:55 ` Sean Christopherson
2021-05-04 20:26 ` Paolo Bonzini
2021-05-04 20:36 ` Sean Christopherson
2021-04-29 21:18 ` [PATCH v2 2/7] KVM: x86/mmu: Skip rmap operations if shadow MMU inactive Ben Gardon
2021-04-29 21:18 ` [PATCH v2 3/7] KVM: x86/mmu: Deduplicate rmap freeing Ben Gardon
2021-04-29 21:18 ` [PATCH v2 4/7] KVM: x86/mmu: Factor out allocating memslot rmap Ben Gardon
2021-04-29 21:18 ` [PATCH v2 5/7] KVM: mmu: Refactor memslot copy Ben Gardon
2021-04-29 21:18 ` [PATCH v2 6/7] KVM: mmu: Add slots_arch_lock for memslot arch fields Ben Gardon
2021-05-03 13:29 ` Paolo Bonzini
2021-04-29 21:18 ` [PATCH v2 7/7] KVM: x86/mmu: Lazily allocate memslot rmaps Ben Gardon
2021-05-03 13:42 ` Paolo Bonzini
2021-05-03 17:29 ` Ben Gardon
2021-05-04 20:13 ` Sean Christopherson
2021-05-04 20:19 ` Paolo Bonzini
2021-05-04 20:34 ` Sean Christopherson
2021-05-04 20:22 ` Paolo Bonzini [this message]
2021-05-03 13:44 ` [PATCH v2 0/7] " Paolo Bonzini
2021-05-03 17:31 ` Ben Gardon
2021-05-04 7:21 ` Paolo Bonzini
2021-05-04 17:28 ` Ben Gardon
2021-05-04 18:17 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e50ae22-16a3-c43d-594a-a20d2ea3caa5@redhat.com \
--to=pbonzini@redhat.com \
--cc=bgardon@google.com \
--cc=jmattson@google.com \
--cc=junaids@google.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=pshier@google.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yulei.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).